Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 01:05:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1569440 - [mozrunner] Log when minidumps directory does not exist on device; r=gbrown

Browse Source 
The missing directory seems to happens ~20 or so times per test run. I hope this
can help with investigations.

Differential Revision: https://phabricator.services.mozilla.com/D39613

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Maja Frydrychowicz 2019-07-30 16:19:03 +00:00
parent 0a6568a4c0
commit 2b9bdaaf17
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
testing/mozbase/mozrunner/mozrunner/devices/base.py
View File

@ -59,12 +59,18 @@ class Device(object):
"""
remote_dump_dir = posixpath.join(self.app_ctx.remote_profile, 'minidumps')
local_dump_dir = tempfile.mkdtemp()
if not self.device.is_dir(remote_dump_dir):
# This may be a hint that something went wrong during browser
# start-up if (MOZ_CRASHREPORTER=1)
print("WARNING: No crash directory {} found on remote device".format(remote_dump_dir))
try:
self.device.pull(remote_dump_dir, local_dump_dir)
except ADBError as e:
# OK if directory not present -- sometimes called before browser start
if 'does not exist' not in str(e):
raise
else:
print("WARNING: {}".format(e))
if os.listdir(local_dump_dir):
self.device.rm(remote_dump_dir, recursive=True)
return local_dump_dir