Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 08:15:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1577650 - Stop using using namespace std in Gecko Profiler - r=canaltinova

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D44076

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Gerald Squelart 2019-08-30 09:40:30 +00:00
parent cc6958bf73
commit 2c3f65a2cf
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mozglue/baseprofiler/core/VTuneProfiler.cpp
View File

@ -17,8 +17,6 @@
# include <memory> # include <memory>
using namespace std;
namespace mozilla { namespace mozilla {
namespace baseprofiler { namespace baseprofiler {
@ -43,7 +41,7 @@ void VTuneProfiler::Shutdown() {}
void VTuneProfiler::TraceInternal(const char* aName, TracingKind aKind) { void VTuneProfiler::TraceInternal(const char* aName, TracingKind aKind) {
// TODO re-implement here if vtune is needed // TODO re-implement here if vtune is needed
// string str(aName); // std::string str(aName);
// auto iter = mStrings.find(str); // auto iter = mStrings.find(str);
@ -67,7 +65,7 @@ void VTuneProfiler::TraceInternal(const char* aName, TracingKind aKind) {
void VTuneProfiler::RegisterThreadInternal(const char* aName) { void VTuneProfiler::RegisterThreadInternal(const char* aName) {
// TODO re-implement here if vtune is needed // TODO re-implement here if vtune is needed
// string str(aName); // std::string str(aName);
// if (!str.compare("Main Thread (Base Profiler)")) { // if (!str.compare("Main Thread (Base Profiler)")) {
// // Process main thread. // // Process main thread.

6
tools/profiler/core/VTuneProfiler.cpp
View File

@ -13,8 +13,6 @@
#include "mozilla/Bootstrap.h" #include "mozilla/Bootstrap.h"
#include <memory> #include <memory>
using namespace std;
VTuneProfiler* VTuneProfiler::mInstance = nullptr; VTuneProfiler* VTuneProfiler::mInstance = nullptr;
void VTuneProfiler::Initialize() { void VTuneProfiler::Initialize() {
@ -34,7 +32,7 @@ void VTuneProfiler::Initialize() {
void VTuneProfiler::Shutdown() {} void VTuneProfiler::Shutdown() {}
void VTuneProfiler::TraceInternal(const char* aName, TracingKind aKind) { void VTuneProfiler::TraceInternal(const char* aName, TracingKind aKind) {
string str(aName); std::string str(aName);
auto iter = mStrings.find(str); auto iter = mStrings.find(str);
@ -56,7 +54,7 @@ void VTuneProfiler::TraceInternal(const char* aName, TracingKind aKind) {
} }
void VTuneProfiler::RegisterThreadInternal(const char* aName) { void VTuneProfiler::RegisterThreadInternal(const char* aName) {
string str(aName); std::string str(aName);
if (!str.compare("GeckoMain")) { if (!str.compare("GeckoMain")) {
// Process main thread. // Process main thread.