Backed out changeset be4fd8ee7afd (bug 1483985) for causing build bustages on LookupCache. CLOSED TREE

dom/storage/LocalStorageManager.cpp

@@ -142,7 +142,7 @@ LocalStorageManager::CreateOrigin(const nsACString& aOriginSuffix,
   scope.Append(aOriginSuffix);
   scope.Append(':');
   scope.Append(aOriginNoSuffix);
-  return std::move(scope);
+  return scope;
 }
 
 LocalStorageCache*

gfx/thebes/gfxPlatform.cpp

@@ -1668,7 +1668,7 @@ gfxPlatform::GetDefaultFontName(const nsACString& aLangGroup,
       fontFamily->LocalizedName(result);
     } // (else, leave 'result' empty)
 
-    return std::move(result);
+    return result;
 }
 
 bool

layout/painting/DisplayItemClip.cpp

@@ -545,7 +545,7 @@ DisplayItemClip::ToString() const
                        r.mRadii[4], r.mRadii[5], r.mRadii[6], r.mRadii[7]);
     }
   }
-  return std::move(str);
+  return str;
 }
 
 void

layout/painting/DisplayItemClipChain.cpp

@@ -79,7 +79,7 @@ DisplayItemClipChain::ToString(const DisplayItemClipChain* aClipChain)
       str.AppendLiteral(", ");
     }
   }
-  return std::move(str);
+  return str;
 }
 
 bool

layout/painting/nsDisplayList.cpp

@@ -174,7 +174,7 @@ ActiveScrolledRoot::ToString(const ActiveScrolledRoot* aActiveScrolledRoot)
       str.AppendLiteral(", ");
     }
   }
-  return std::move(str);
+  return str;
 }
 
 static inline CSSAngle

toolkit/components/extensions/WebExtensionPolicy.cpp

@@ -459,7 +459,7 @@ WebExtensionPolicy::BackgroundPageHTML() const
 
   if (mBackgroundScripts.IsNull()) {
     result.SetIsVoid(true);
-    return std::move(result);
+    return result;
   }
 
   result.AppendLiteral(kBackgroundPageHTMLStart);
@@ -472,7 +472,7 @@ WebExtensionPolicy::BackgroundPageHTML() const
   }
 
   result.AppendLiteral(kBackgroundPageHTMLEnd);
-  return std::move(result);
+  return result;
 }
 
 void

toolkit/components/url-classifier/LookupCache.h

@@ -60,7 +60,7 @@ public:
     for (size_t i = 0; i < mPartialHashLength; i++) {
       hex.AppendPrintf("%.2X", hash.complete.buf[i]);
     }
-    return std::move(hex);
+    return hex;
   }
 
   bool Confirmed() const { return mConfirmed || mProtocolConfirmed; }