Bug 1509931 - Remove -moz-gtk-csd-transparent-background. r=stransky,desktop-theme-reviewers,dao

We always use alpha visual for WebRender, and appearance: none is
unnecessary (root element has no intrinsic appearance).

Differential Revision: https://phabricator.services.mozilla.com/D128682
This commit is contained in:
Emilio Cobos Álvarez 2021-10-18 18:51:41 +00:00
parent d89f68f599
commit 2cdb78d6a6
9 changed files with 2 additions and 31 deletions

View File

@ -333,16 +333,8 @@ menuitem.bookmark-item {
/* We draw to titlebar when Gkt+ CSD is available */
@media (-moz-gtk-csd-available) {
/* Some Gtk+ themes use non-rectangular toplevel windows. To fully support
* such themes we need to make toplevel window transparent.
* It may cause performance issues so let's put it under a preference
* and enable it for desktop environment which do that by default.
* See nsWindow::TopLevelWindowUseARGBVisual() for details. */
@media (-moz-gtk-csd-transparent-background) {
:root[tabsintitlebar][sizemode="normal"]:not(:-moz-lwtheme) {
background-color: transparent;
appearance: none;
}
:root[tabsintitlebar][sizemode="normal"]:not(:-moz-lwtheme) {
background-color: transparent;
}
:root[tabsintitlebar] #titlebar {

View File

@ -62,7 +62,6 @@ var suppressed_toggles = [
"-moz-windows-glass",
"-moz-gtk-csd-available",
"-moz-gtk-csd-hide-titlebar-by-default",
"-moz-gtk-csd-transparent-background",
"-moz-gtk-csd-minimize-button",
"-moz-gtk-csd-maximize-button",
"-moz-gtk-csd-close-button",

View File

@ -22,7 +22,6 @@ const CHROME_ONLY_TOGGLES = [
"-moz-swipe-animation-enabled",
"-moz-gtk-csd-available",
"-moz-gtk-csd-hide-titlebar-by-default",
"-moz-gtk-csd-transparent-background",
"-moz-gtk-csd-minimize-button",
"-moz-gtk-csd-maximize-button",
"-moz-gtk-csd-close-button",

View File

@ -891,7 +891,6 @@ pub static MEDIA_FEATURES: [MediaFeatureDescription; 60] = [
lnf_int_feature!(atom!("-moz-swipe-animation-enabled"), SwipeAnimationEnabled),
lnf_int_feature!(atom!("-moz-gtk-csd-available"), GTKCSDAvailable),
lnf_int_feature!(atom!("-moz-gtk-csd-hide-titlebar-by-default"), GTKCSDHideTitlebarByDefault),
lnf_int_feature!(atom!("-moz-gtk-csd-transparent-background"), GTKCSDTransparentBackground),
lnf_int_feature!(atom!("-moz-gtk-csd-minimize-button"), GTKCSDMinimizeButton),
lnf_int_feature!(atom!("-moz-gtk-csd-maximize-button"), GTKCSDMaximizeButton),
lnf_int_feature!(atom!("-moz-gtk-csd-close-button"), GTKCSDCloseButton),

View File

@ -252,12 +252,6 @@ class LookAndFeel {
*/
GTKCSDHideTitlebarByDefault,
/*
* A boolean value indicating whether client-side decorations should
* have transparent background.
*/
GTKCSDTransparentBackground,
/*
* A boolean value indicating whether client-side decorations should
* contain a minimize button.

View File

@ -805,15 +805,6 @@ nsresult nsLookAndFeel::NativeGetInt(IntID aID, int32_t& aResult) {
EnsureInit();
aResult = mCSDCloseButton;
break;
case IntID::GTKCSDTransparentBackground: {
// Enable transparent titlebar corners for titlebar mode.
GdkScreen* screen = gdk_screen_get_default();
aResult = gdk_screen_is_composited(screen)
? (nsWindow::GtkWindowDecoration() !=
nsWindow::GTK_DECORATION_NONE)
: false;
break;
}
case IntID::GTKCSDReversedPlacement:
EnsureInit();
aResult = mCSDReversedPlacement;

View File

@ -257,7 +257,6 @@ nsresult HeadlessLookAndFeel::NativeGetInt(IntID aID, int32_t& aResult) {
break;
case IntID::GTKCSDAvailable:
case IntID::GTKCSDHideTitlebarByDefault:
case IntID::GTKCSDTransparentBackground:
aResult = 0;
break;
case IntID::GTKCSDMinimizeButton:

View File

@ -161,7 +161,6 @@ static const char sIntPrefs[][43] = {
"ui.contextMenuOffsetHorizontal",
"ui.GtkCSDAvailable",
"ui.GtkCSDHideTitlebarByDefault",
"ui.GtkCSDTransparentBackground",
"ui.GtkCSDMinimizeButton",
"ui.GtkCSDMaximizeButton",
"ui.GtkCSDCloseButton",

View File

@ -2227,7 +2227,6 @@ STATIC_ATOMS = [
Atom("_moz_gtk_csd_available", "-moz-gtk-csd-available"),
Atom("_moz_gtk_csd_hide_titlebar_by_default", "-moz-gtk-csd-hide-titlebar-by-default"),
Atom("_moz_gtk_csd_titlebar_radius", "-moz-gtk-csd-titlebar-radius"),
Atom("_moz_gtk_csd_transparent_background", "-moz-gtk-csd-transparent-background"),
Atom("_moz_gtk_csd_minimize_button", "-moz-gtk-csd-minimize-button"),
Atom("_moz_gtk_csd_maximize_button", "-moz-gtk-csd-maximize-button"),
Atom("_moz_gtk_csd_close_button", "-moz-gtk-csd-close-button"),