Backed out changeset 591cf97d4777 (bug 1427077) for ES failures in /builds/worker/checkouts/gecko/devtools/client/shared/webpack/rewrite-lazy-getter.js r=backout on a CLOSED TREE

This commit is contained in:
Noemi Erli 2018-01-04 10:42:44 +02:00
parent 351ae38da6
commit 2da14c0702
4 changed files with 28 additions and 76 deletions

View File

@ -15,6 +15,7 @@ const { FILTER_SEARCH_DELAY } = require("../constants");
// Components
const TreeViewClass = require("devtools/client/shared/components/tree/TreeView");
const TreeView = createFactory(TreeViewClass);
const SearchBox = createFactory(require("devtools/client/shared/components/SearchBox"));
loader.lazyGetter(this, "SearchBox", function () {
return createFactory(require("devtools/client/shared/components/SearchBox"));

View File

@ -38,66 +38,33 @@ const { RESPONSE_HEADERS } = require("../constants");
RequestListColumnWaterfall
*/
loader.lazyGetter(this, "RequestListColumnCause", function () {
return createFactory(require("./RequestListColumnCause"));
});
loader.lazyGetter(this, "RequestListColumnContentSize", function () {
return createFactory(require("./RequestListColumnContentSize"));
});
loader.lazyGetter(this, "RequestListColumnCookies", function () {
return createFactory(require("./RequestListColumnCookies"));
});
loader.lazyGetter(this, "RequestListColumnDomain", function () {
return createFactory(require("./RequestListColumnDomain"));
});
loader.lazyGetter(this, "RequestListColumnDuration", function () {
return createFactory(require("./RequestListColumnDuration"));
});
loader.lazyGetter(this, "RequestListColumnEndTime", function () {
return createFactory(require("./RequestListColumnEndTime"));
});
loader.lazyGetter(this, "RequestListColumnFile", function () {
return createFactory(require("./RequestListColumnFile"));
});
loader.lazyGetter(this, "RequestListColumnLatency", function () {
return createFactory(require("./RequestListColumnLatency"));
});
loader.lazyGetter(this, "RequestListColumnMethod", function () {
return createFactory(require("./RequestListColumnMethod"));
});
loader.lazyGetter(this, "RequestListColumnProtocol", function () {
return createFactory(require("./RequestListColumnProtocol"));
});
loader.lazyGetter(this, "RequestListColumnRemoteIP", function () {
return createFactory(require("./RequestListColumnRemoteIP"));
});
loader.lazyGetter(this, "RequestListColumnResponseHeader", function () {
return createFactory(require("./RequestListColumnResponseHeader"));
});
loader.lazyGetter(this, "RequestListColumnResponseTime", function () {
return createFactory(require("./RequestListColumnResponseTime"));
});
loader.lazyGetter(this, "RequestListColumnScheme", function () {
return createFactory(require("./RequestListColumnScheme"));
});
loader.lazyGetter(this, "RequestListColumnSetCookies", function () {
return createFactory(require("./RequestListColumnSetCookies"));
});
loader.lazyGetter(this, "RequestListColumnStartTime", function () {
return createFactory(require("./RequestListColumnStartTime"));
});
loader.lazyGetter(this, "RequestListColumnStatus", function () {
return createFactory(require("./RequestListColumnStatus"));
});
loader.lazyGetter(this, "RequestListColumnTransferredSize", function () {
return createFactory(require("./RequestListColumnTransferredSize"));
});
loader.lazyGetter(this, "RequestListColumnType", function () {
return createFactory(require("./RequestListColumnType"));
});
loader.lazyGetter(this, "RequestListColumnWaterfall", function () {
return createFactory(require("./RequestListColumnWaterfall"));
});
const COLUMNS = [
"Cause",
"ContentSize",
"Cookies",
"Domain",
"Duration",
"EndTime",
"File",
"Latency",
"Method",
"Protocol",
"RemoteIP",
"ResponseHeader",
"ResponseTime",
"Scheme",
"SetCookies",
"StartTime",
"Status",
"TransferredSize",
"Type",
"Waterfall"
];
for (let name of COLUMNS) {
loader.lazyGetter(this, "RequestListColumn" + name, function () {
return createFactory(require("./RequestListColumn" + name));
});
}
/**
* Used by shouldComponentUpdate: compare two items, and compare only properties

View File

@ -39,8 +39,6 @@ let webpackConfig = {
"rewrite-browser-require",
// Replace all references to loader.lazyRequire() by require()
"rewrite-lazy-require",
// Replace all references to loader.lazyGetter() by require()
"rewrite-lazy-getter",
],
}
]

View File

@ -1,14 +0,0 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";
module.exports = function (content) {
this.cacheable && this.cacheable();
return content.replace(
/loader.lazyGetter\(this,\s*"([^"]+)"\s*,\s*(function\s*\(\)\s*\{[\s\S]*?\})\);/g,
"let $1 = ($2)();"
);
};