Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-11 20:35:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

add some bulletproofing to the subscribe search view so that we

Browse Source 
check the row.  fixes crasher bug #117065
r/sr=bienvenu
This commit is contained in:
sspitzer%netscape.com 2002-01-08 01:32:27 +00:00
parent 5965318acb
commit 2da5458bd8
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
mailnews/news/src/nsNntpIncomingServer.cpp
View File

@ -1775,6 +1775,9 @@ nsNntpIncomingServer::GetRowProperties(PRInt32 index, nsISupportsArray *properti
NS_IMETHODIMP
nsNntpIncomingServer::GetCellProperties(PRInt32 row, const PRUnichar *colID, nsISupportsArray *properties)
{
if (!IsValidRow(row))
return NS_ERROR_UNEXPECTED;
if (colID[0] == 's') {
// if <name> is in our temporary list of subscribed groups
// add the "subscribed" property so the check mark shows up
@ -1868,9 +1871,18 @@ nsNntpIncomingServer::GetLevel(PRInt32 index, PRInt32 *_retval)
return NS_OK;
}
nsresult
nsNntpIncomingServer::IsValidRow(PRInt32 row)
{
return ((row >= 0) && (row < mSubscribeSearchResult.Count()));
}
NS_IMETHODIMP
nsNntpIncomingServer::GetCellText(PRInt32 row, const PRUnichar *colID, nsAString& _retval)
{
if (!IsValidRow(row))
return NS_ERROR_UNEXPECTED;
if (colID[0] == 'n') {
nsCString str;
mSubscribeSearchResult.CStringAt(row, str);

3
mailnews/news/src/nsNntpIncomingServer.h
View File

@ -154,7 +154,8 @@ private:
nsCOMPtr <nsISubscribableServer> mInner;
nsresult EnsureInner();
nsresult ClearInner();
nsresult IsValidRow(PRInt32 row);
nsIOFileStream *mHostInfoStream;
nsCOMPtr<nsIFileSpec> mNewsrcFilePath;
};