Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 11:25:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1480365: WebAuthManager doesn't need to keep alive AbortSignal, r=smaug

Browse Source
This commit is contained in:
Andrea Marchesini 2018-08-06 21:01:53 +02:00
parent 36b1f729cb
commit 2dd8d57be4
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dom/webauthn/WebAuthnManager.cpp
View File

@ -402,7 +402,7 @@ WebAuthnManager::MakeCredential(const PublicKeyCredentialCreationOptions& aOptio
}
MOZ_ASSERT(mTransaction.isNothing());
mTransaction = Some(WebAuthnTransaction(promise, signal));
mTransaction = Some(WebAuthnTransaction(promise));
mChild->SendRequestRegister(mTransaction.ref().mId, info);
return promise.forget();
@ -582,7 +582,7 @@ WebAuthnManager::GetAssertion(const PublicKeyCredentialRequestOptions& aOptions,
}
MOZ_ASSERT(mTransaction.isNothing());
mTransaction = Some(WebAuthnTransaction(promise, signal));
mTransaction = Some(WebAuthnTransaction(promise));
mChild->SendRequestSign(mTransaction.ref().mId, info);
return promise.forget();

7
dom/webauthn/WebAuthnManager.h
View File

@ -47,10 +47,8 @@ namespace dom {
class WebAuthnTransaction
{
public:
WebAuthnTransaction(const RefPtr<Promise>& aPromise,
AbortSignal* aSignal)
explicit WebAuthnTransaction(const RefPtr<Promise>& aPromise)
: mPromise(aPromise)
, mSignal(aSignal)
, mId(NextId())
{
MOZ_ASSERT(mId > 0);
@ -59,9 +57,6 @@ public:
// JS Promise representing the transaction status.
RefPtr<Promise> mPromise;
// An optional AbortSignal instance.
RefPtr<AbortSignal> mSignal;
// Unique transaction id.
uint64_t mId;