Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-24 10:45:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1266792 - Don't play opus with AndroidDecoderModule. r=jya

Browse Source 
The android 5.1.1 OMX decoder claims to support audio/opus
but crashes on the output of our mp4 demuxer. Work around
this by rejecting the mime type, allowing fallback to the
libopus-based AgnosticDecoderModule.

In any case, since we're shipping the libopus-based decoder
we're prefer to use it for consistency.

MozReview-Commit-ID: GQaTMALajnZ

--HG--
extra : rebase_source : fb43ddc6bd7b5ed92308124045ad2330a8043f46
This commit is contained in:
Ralph Giles 2016-10-31 16:39:03 -07:00
parent 92e243086a
commit 2de2f42926
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dom/media/platforms/android/AndroidDecoderModule.cpp
View File

@ -151,6 +151,13 @@ AndroidDecoderModule::SupportsMimeType(const nsACString& aMimeType,
return false;
}
// Prefer the gecko decoder for opus; stagefright crashes
// on content demuxed from mp4.
if (aMimeType.EqualsLiteral("audio/opus")) {
LOG("Rejecting audio of type %s", aMimeType.Data());
return false;
}
return java::HardwareCodecCapabilityUtils::FindDecoderCodecInfoForMimeType(
nsCString(TranslateMimeType(aMimeType)));
}