Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-28 15:23:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1694685 part 5 - Replace JS_CHECK_ACCESSOR_FLAGS macro with a C++ template. r=tcampbell

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D106409
This commit is contained in:
Jan de Mooij 2021-03-08 12:07:15 +00:00
parent 39f486ec3a
commit 2eb2d5e541
1 changed files with 21 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
js/public/PropertySpec.h
View File

@ -354,31 +354,32 @@ struct JSPropertySpec {
// - AccessorsOrValue (4 words, native + JSJitInfo for both getter and setter)
static_assert(sizeof(JSPropertySpec) == 6 * sizeof(uintptr_t));
#define JS_CHECK_ACCESSOR_FLAGS(attributes) \
(static_cast<std::enable_if_t< \
((attributes) & ~(JSPROP_ENUMERATE | JSPROP_PERMANENT)) == 0>>(0), \
(attributes))
template <unsigned Attributes>
constexpr uint8_t CheckAccessorAttrs() {
static_assert((Attributes & ~(JSPROP_ENUMERATE | JSPROP_PERMANENT)) == 0,
"Unexpected flag (not JSPROP_ENUMERATE or JSPROP_PERMANENT)");
return uint8_t(Attributes);
}
#define JS_PSG(name, getter, attributes) \
JSPropertySpec::nativeAccessors(name, JS_CHECK_ACCESSOR_FLAGS(attributes), \
#define JS_PSG(name, getter, attributes) \
JSPropertySpec::nativeAccessors(name, CheckAccessorAttrs<attributes>(), \
getter, nullptr)
#define JS_PSGS(name, getter, setter, attributes) \
JSPropertySpec::nativeAccessors(name, JS_CHECK_ACCESSOR_FLAGS(attributes), \
#define JS_PSGS(name, getter, setter, attributes) \
JSPropertySpec::nativeAccessors(name, CheckAccessorAttrs<attributes>(), \
getter, nullptr, setter, nullptr)
#define JS_SYM_GET(symbol, getter, attributes) \
JSPropertySpec::nativeAccessors(::JS::SymbolCode::symbol, \
JS_CHECK_ACCESSOR_FLAGS(attributes), getter, \
#define JS_SYM_GET(symbol, getter, attributes) \
JSPropertySpec::nativeAccessors(::JS::SymbolCode::symbol, \
CheckAccessorAttrs<attributes>(), getter, \
nullptr)
#define JS_SELF_HOSTED_GET(name, getterName, attributes) \
JSPropertySpec::selfHostedAccessors( \
name, JS_CHECK_ACCESSOR_FLAGS(attributes), getterName)
#define JS_SELF_HOSTED_GETSET(name, getterName, setterName, attributes) \
JSPropertySpec::selfHostedAccessors( \
name, JS_CHECK_ACCESSOR_FLAGS(attributes), getterName, setterName)
#define JS_SELF_HOSTED_SYM_GET(symbol, getterName, attributes) \
JSPropertySpec::selfHostedAccessors(::JS::SymbolCode::symbol, \
JS_CHECK_ACCESSOR_FLAGS(attributes), \
#define JS_SELF_HOSTED_GET(name, getterName, attributes) \
JSPropertySpec::selfHostedAccessors(name, CheckAccessorAttrs<attributes>(), \
getterName)
#define JS_SELF_HOSTED_GETSET(name, getterName, setterName, attributes) \
JSPropertySpec::selfHostedAccessors(name, CheckAccessorAttrs<attributes>(), \
getterName, setterName)
#define JS_SELF_HOSTED_SYM_GET(symbol, getterName, attributes) \
JSPropertySpec::selfHostedAccessors( \
::JS::SymbolCode::symbol, CheckAccessorAttrs<attributes>(), getterName)
#define JS_STRING_PS(name, string, attributes) \
JSPropertySpec::stringValue(name, attributes, string)
#define JS_STRING_SYM_PS(symbol, string, attributes) \