From 2ebc193413ba30e8ff4c591e3b0846de46659dc0 Mon Sep 17 00:00:00 2001 From: "pete%alphanumerica.com" Date: Sun, 29 Apr 2001 17:51:14 +0000 Subject: [PATCH] removing Wshadow flag. see bug 5621 sr=cls r=leaf --pete --- configure | 5 +++-- configure.in | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/configure b/configure index fb3f6d564036..aa46cd71d323 100755 --- a/configure +++ b/configure @@ -4200,7 +4200,8 @@ if test "$GNU_CC"; then # Warnings slamm took out for now (these were giving more noise than help): # -Wbad-function-cast - warns when casting a function to a new return type # -Wconversion - complained when char's or short's were used a function args - _WARNINGS_CFLAGS="${_WARNINGS_CFLAGS} -Wall -W -Wno-unused -Wshadow -Wpointer-arith -Wcast-align" + # -Wshadow - removed because it generates more noise than help --pete + _WARNINGS_CFLAGS="${_WARNINGS_CFLAGS} -Wall -W -Wno-unused -Wpointer-arith -Wcast-align" _PEDANTIC=1 _IGNORE_LONG_LONG_WARNINGS=1 @@ -4221,7 +4222,7 @@ if test "$GNU_CXX"; then _WARNINGS_CXXFLAGS="${_WARNINGS_CXXFLAGS} -Wall -Wconversion -Wpointer-arith -Wbad-function-cast -Wcast-align -Woverloaded-virtual -Wsynth" if test ! "$QTDIR"; then - _WARNINGS_CXXFLAGS="${_WARNINGS_CXXFLAGS} -Wshadow" + _WARNINGS_CXXFLAGS="${_WARNINGS_CXXFLAGS}" fi _DEFINES_CXXFLAGS='-DMOZILLA_CLIENT -include $(DEPTH)/config-defs.h' diff --git a/configure.in b/configure.in index e872117ec49a..e84aee2fb9f8 100644 --- a/configure.in +++ b/configure.in @@ -486,7 +486,8 @@ if test "$GNU_CC"; then # Warnings slamm took out for now (these were giving more noise than help): # -Wbad-function-cast - warns when casting a function to a new return type # -Wconversion - complained when char's or short's were used a function args - _WARNINGS_CFLAGS="${_WARNINGS_CFLAGS} -Wall -W -Wno-unused -Wshadow -Wpointer-arith -Wcast-align" + # -Wshadow - removed because it generates more noise than help --pete + _WARNINGS_CFLAGS="${_WARNINGS_CFLAGS} -Wall -W -Wno-unused -Wpointer-arith -Wcast-align" dnl Turn pedantic on but disable the warnings for long long _PEDANTIC=1 @@ -509,7 +510,7 @@ if test "$GNU_CXX"; then dnl The following warning breaks Qt if test ! "$QTDIR"; then - _WARNINGS_CXXFLAGS="${_WARNINGS_CXXFLAGS} -Wshadow" + _WARNINGS_CXXFLAGS="${_WARNINGS_CXXFLAGS}" fi _DEFINES_CXXFLAGS='-DMOZILLA_CLIENT -include $(DEPTH)/config-defs.h'