Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-28 21:28:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix leak in table background painting. Bug 295236, r=bernd, sr=dveditz, a=asa

Browse Source
This commit is contained in:
bzbarsky%mit.edu 2005-05-24 04:15:05 +00:00
parent c61f3f6d37
commit 2f16a8de39
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
layout/tables/nsTablePainter.cpp
View File

@ -406,6 +406,9 @@ TableBackgroundPainter::PaintTable(nsTableFrame* aTableFrame,
} }
} }
// Boolean that indicates whether mCols took ownership of cgData
PRBool cgDataOwnershipTaken = PR_FALSE;
/*Loop over columns in this colgroup*/ /*Loop over columns in this colgroup*/
if (cgData->IsVisible()) { if (cgData->IsVisible()) {
for (nsTableColFrame* col = cgFrame->GetFirstColumn(); col; for (nsTableColFrame* col = cgFrame->GetFirstColumn(); col;
@ -420,6 +423,7 @@ TableBackgroundPainter::PaintTable(nsTableFrame* aTableFrame,
mCols[colIndex].mCol.mRect.MoveBy(cgData->mRect.x, cgData->mRect.y); mCols[colIndex].mCol.mRect.MoveBy(cgData->mRect.x, cgData->mRect.y);
//link to parent colgroup's data //link to parent colgroup's data
mCols[colIndex].mColGroup = cgData; mCols[colIndex].mColGroup = cgData;
cgDataOwnershipTaken = PR_TRUE;
if (mIsBorderCollapse) { if (mIsBorderCollapse) {
border.left = lastLeftBorder; border.left = lastLeftBorder;
lastLeftBorder = col->GetContinuousBCBorderWidth(mP2t, border); lastLeftBorder = col->GetContinuousBCBorderWidth(mP2t, border);
@ -430,6 +434,11 @@ TableBackgroundPainter::PaintTable(nsTableFrame* aTableFrame,
} }
} }
} }
if (!cgDataOwnershipTaken) {
cgData->Destroy(mPresContext);
delete cgData;
}
} }
} }