Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 22:01:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 483788. Don't leak if a broken protocol handler returns a channel but error rv. r=bsmedberg, moa=biesi

Browse Source
This commit is contained in:
Boris Zbarsky 2009-03-23 14:53:14 -04:00
parent e29d8ab4e4
commit 30a3d1ae6c
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
netwerk/base/public/nsNetUtil.h
View File

@ -177,8 +177,8 @@ NS_NewChannel(nsIChannel **result,
nsCOMPtr<nsIIOService> grip;
rv = net_EnsureIOService(&ioService, grip);
if (ioService) {
nsIChannel *chan;
rv = ioService->NewChannelFromURI(uri, &chan);
nsCOMPtr<nsIChannel> chan;
rv = ioService->NewChannelFromURI(uri, getter_AddRefs(chan));
if (NS_SUCCEEDED(rv)) {
if (loadGroup)
rv |= chan->SetLoadGroup(loadGroup);
@ -187,9 +187,7 @@ NS_NewChannel(nsIChannel **result,
if (loadFlags != nsIRequest::LOAD_NORMAL)
rv |= chan->SetLoadFlags(loadFlags);
if (NS_SUCCEEDED(rv))
*result = chan;
else
NS_RELEASE(chan);
chan.forget(result);
}
}
return rv;