Bug 1162729 - CORS check is always performed when fetching a manifest. r=ehsan

--HG--
extra : rebase_source : 714b7abcf3f700685d538800af89578b14f7b622

dom/ipc/manifestMessages.js

@@ -69,20 +69,11 @@ function fetchManifest() {
     }
     // Will throw on "about:blank" and possibly other invalid URIs.
     const manifestURL = new content.URL(elem.href, elem.baseURI);
-    const reqInit = {};
-    switch (elem.crossOrigin) {
-      case 'use-credentials':
-        reqInit.credentials = 'include';
-        reqInit.mode = 'cors';
-        break;
-      case 'anonymous':
-        reqInit.credentials = 'omit';
-        reqInit.mode = 'cors';
-        break;
-      default:
-        reqInit.credentials = 'same-origin';
-        reqInit.mode = 'no-cors';
-        break;
+    const reqInit = {
+      mode: 'cors'
+    };
+    if (elem.crossOrigin === 'use-credentials') {
+      reqInit.credentials = 'include';
     }
     const req = new content.Request(manifestURL, reqInit);
     req.setContext('manifest');

dom/manifest/test/browser_ManifestObtainer_obtain.js

@@ -44,7 +44,7 @@ const tests = [
       <link rel="manifest" href='resource.sjs?body={"name":"fail"}'>
       <link rel="manifest foo bar test" href='resource.sjs?body={"name":"fail"}'>`
   }, {
-    expected: 'By default, manifest load cross-origin.',
+    expected: 'By default, manifest cannot load cross-origin.',
     get tabURL() {
       let query = [
         `body=<h1>${this.expected}</h1>`,
@@ -53,9 +53,8 @@ const tests = [
       const URL = `${defaultURL}?${query.join('&')}`;
       return URL;
     },
-    run(manifest) {
-      // Waiting on https://bugzilla.mozilla.org/show_bug.cgi?id=1130924
-      todo_is(manifest.name, 'pass-3', this.expected);
+    run(err) {
+      Assert.strictEqual(err.name, 'TypeError', this.expected);
     },
     testData: `<link rel="manifest" href='${remoteURL}?body={"name":"pass-3"}'>`
   },