Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-26 20:30:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1532599 - Force expected crashes on unexpected magic values. r=jandem

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D22120

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Nicolas B. Pierron 2019-03-06 20:23:43 +00:00
parent 51578aa0fc
commit 324a5a5901
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
js/public/Value.h
View File

@ -656,8 +656,11 @@ union alignas(8) Value {
bool isMagic() const { return toTag() == JSVAL_TAG_MAGIC; }
bool isMagic(JSWhyMagic why) const {
MOZ_ASSERT_IF(isMagic(), s_.payload_.why_ == why);
return isMagic();
if (!isMagic()) {
return false;
}
MOZ_RELEASE_ASSERT(s_.payload_.why_ == why);
return true;
}
JS::TraceKind traceKind() const {