Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 17:55:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1589122 - Rename some arguments from settings to prefs where appropriate r=canaltinova

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D49645

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Julien Wajsberg 2019-10-22 08:14:00 +00:00
parent 2ef21585f6
commit 333cd53ceb
2 changed files with 15 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
devtools/client/performance-new/browser.js
View File

@ -267,19 +267,16 @@ async function getRecordingPreferencesFromDebuggee(
* debuggee, and some of them on the host browser instance.
*
* @param {PreferenceFront} preferenceFront
* @param {RecordingStateFromPreferences} settings
* @param {RecordingStateFromPreferences} prefs
*/
async function setRecordingPreferencesOnDebuggee(preferenceFront, settings) {
async function setRecordingPreferencesOnDebuggee(preferenceFront, prefs) {
const { Services } = lazyServices();
await Promise.all([
preferenceFront.setIntPref(ENTRIES_PREF, settings.entries),
preferenceFront.setIntPref(INTERVAL_PREF, settings.interval),
preferenceFront.setCharPref(
FEATURES_PREF,
JSON.stringify(settings.features)
),
preferenceFront.setCharPref(THREADS_PREF, JSON.stringify(settings.threads)),
Services.prefs.setCharPref(OBJDIRS_PREF, JSON.stringify(settings.objdirs)),
preferenceFront.setIntPref(ENTRIES_PREF, prefs.entries),
preferenceFront.setIntPref(INTERVAL_PREF, prefs.interval),
preferenceFront.setCharPref(FEATURES_PREF, JSON.stringify(prefs.features)),
preferenceFront.setCharPref(THREADS_PREF, JSON.stringify(prefs.threads)),
Services.prefs.setCharPref(OBJDIRS_PREF, JSON.stringify(prefs.objdirs)),
]);
}

15
devtools/client/performance-new/popup/background.jsm.js
View File

@ -337,14 +337,15 @@ function getRecordingPreferencesFromBrowser() {
}
/**
* @param {RecordingStateFromPreferences} settings
* @param {RecordingStateFromPreferences} prefs
*/
function setRecordingPreferencesOnBrowser(settings) {
Services.prefs.setIntPref(ENTRIES_PREF, settings.entries);
Services.prefs.setIntPref(INTERVAL_PREF, settings.interval);
Services.prefs.setCharPref(FEATURES_PREF, JSON.stringify(settings.features));
Services.prefs.setCharPref(THREADS_PREF, JSON.stringify(settings.threads));
Services.prefs.setCharPref(OBJDIRS_PREF, JSON.stringify(settings.objdirs));
function setRecordingPreferencesOnBrowser(prefs) {
Services.prefs.setIntPref(ENTRIES_PREF, prefs.entries);
// The interval pref stores the value in microseconds for extra precision.
Services.prefs.setIntPref(INTERVAL_PREF, prefs.interval);
Services.prefs.setCharPref(FEATURES_PREF, JSON.stringify(prefs.features));
Services.prefs.setCharPref(THREADS_PREF, JSON.stringify(prefs.threads));
Services.prefs.setCharPref(OBJDIRS_PREF, JSON.stringify(prefs.objdirs));
}
const platform = AppConstants.platform;