Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-13 03:24:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor (browser parts); r=jrmuizel

Browse Source
This commit is contained in:
Ehsan Akhgari 2012-06-19 23:24:24 -04:00
parent 6236bad8d7
commit 3360fe9dd4
3 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
browser/components/dirprovider/DirectoryProvider.h
View File

@ -9,6 +9,7 @@
#include "nsComponentManagerUtils.h" #include "nsComponentManagerUtils.h"
#include "nsISimpleEnumerator.h" #include "nsISimpleEnumerator.h"
#include "nsIFile.h" #include "nsIFile.h"
#include "mozilla/Attributes.h"
#define NS_BROWSERDIRECTORYPROVIDER_CONTRACTID \ #define NS_BROWSERDIRECTORYPROVIDER_CONTRACTID \
"@mozilla.org/browser/directory-provider;1" "@mozilla.org/browser/directory-provider;1"
@ -16,7 +17,7 @@
namespace mozilla { namespace mozilla {
namespace browser { namespace browser {
class DirectoryProvider : public nsIDirectoryServiceProvider2 class DirectoryProvider MOZ_FINAL : public nsIDirectoryServiceProvider2
{ {
public: public:
NS_DECL_ISUPPORTS NS_DECL_ISUPPORTS
@ -24,7 +25,7 @@ public:
NS_DECL_NSIDIRECTORYSERVICEPROVIDER2 NS_DECL_NSIDIRECTORYSERVICEPROVIDER2
private: private:
class AppendingEnumerator : public nsISimpleEnumerator class AppendingEnumerator MOZ_FINAL : public nsISimpleEnumerator
{ {
public: public:
NS_DECL_ISUPPORTS NS_DECL_ISUPPORTS

4
browser/components/feeds/src/nsFeedSniffer.h
View File

@ -7,8 +7,10 @@
#include "nsIContentSniffer.h" #include "nsIContentSniffer.h"
#include "nsIStreamListener.h" #include "nsIStreamListener.h"
#include "nsStringAPI.h" #include "nsStringAPI.h"
#include "mozilla/Attributes.h"
class nsFeedSniffer : public nsIContentSniffer, nsIStreamListener class nsFeedSniffer MOZ_FINAL : public nsIContentSniffer,
nsIStreamListener
{ {
public: public:
NS_DECL_ISUPPORTS NS_DECL_ISUPPORTS

5
browser/components/privatebrowsing/src/nsPrivateBrowsingServiceWrapper.h
View File

@ -5,11 +5,12 @@
#include "nsCOMPtr.h" #include "nsCOMPtr.h"
#include "nsIPrivateBrowsingService.h" #include "nsIPrivateBrowsingService.h"
#include "nsIObserver.h" #include "nsIObserver.h"
#include "mozilla/Attributes.h"
class nsIJSContextStack; class nsIJSContextStack;
class nsPrivateBrowsingServiceWrapper : public nsIPrivateBrowsingService, class nsPrivateBrowsingServiceWrapper MOZ_FINAL : public nsIPrivateBrowsingService,
public nsIObserver public nsIObserver
{ {
public: public:
NS_DECL_ISUPPORTS NS_DECL_ISUPPORTS