mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-24 21:31:04 +00:00
Bug 1590415 - Remove deprecated code from the Coverity model file. r=sylvestre
Depends on D50065 Differential Revision: https://phabricator.services.mozilla.com/D50066 --HG-- extra : moz-landing-system : lando
This commit is contained in:
parent
611ae752a0
commit
336c0275ee
@ -8,113 +8,6 @@
|
||||
Coverity model file in order to avoid false-positive
|
||||
*/
|
||||
|
||||
#define NULL (void*)0
|
||||
|
||||
typedef unsigned char jsbytecode;
|
||||
typedef unsigned short uint16_t;
|
||||
typedef unsigned int uint32_t;
|
||||
typedef unsigned int int32_t;
|
||||
typedef unsigned char uint8_t;
|
||||
|
||||
static const uint16_t CHUNK_HEAD_SIZE = 8;
|
||||
|
||||
void assert(bool expr) {
|
||||
if (!expr) {
|
||||
__coverity_panic__();
|
||||
}
|
||||
}
|
||||
|
||||
#define ERREXIT(cinfo, err) __coverity_panic__();
|
||||
|
||||
void MOZ_ASSUME_UNREACHABLE(char* str) { __coverity_panic__(); }
|
||||
|
||||
static void MOZ_ReportAssertionFailure(const char* aStr, const char* aFilename,
|
||||
int aLine) {
|
||||
__coverity_panic__();
|
||||
}
|
||||
|
||||
static void MOZ_ReportCrash(const char* aStr, const char* aFilename,
|
||||
int aLine) {
|
||||
__coverity_panic__();
|
||||
}
|
||||
|
||||
#define MOZ_ASSERT(expr, msg) assert(!!(expr))
|
||||
|
||||
#define MOZ_ASSERT(expr) assert(!!(expr))
|
||||
|
||||
#define NS_ASSERTION(expr, msg) assert(!!(expr))
|
||||
|
||||
#define PORT_Assert(expr) assert(!!(expr))
|
||||
|
||||
#define PR_ASSERT(expr) assert(!!(expr))
|
||||
|
||||
// Kills Structurally dead code (UNREACHABLE)
|
||||
#define NS_IMPL_CYCLE_COLLECTION_CAN_SKIP_THIS_BEGIN(_class) \
|
||||
NS_IMETHODIMP_(bool) \
|
||||
NS_CYCLE_COLLECTION_CLASSNAME(_class)::CanSkipThisReal(void* p) { \
|
||||
__coverity_panic__(); \
|
||||
_class* tmp = DowncastCCParticipant<_class>(p);
|
||||
|
||||
int GET_JUMP_OFFSET(jsbytecode* pc) {
|
||||
__coverity_tainted_data_sink__(static_cast<void*>(pc));
|
||||
return 0;
|
||||
}
|
||||
|
||||
// Data sanity checkers
|
||||
#define XPT_SWAB16(data) __coverity_tainted_data_sanitize__(&data)
|
||||
|
||||
#define XPT_SWAB32(data) __coverity_tainted_data_sanitize__(&data)
|
||||
|
||||
static unsigned GET_UINT24(const jsbytecode* pc) {
|
||||
__coverity_tainted_data_sink__(static_cast<void*>(pc));
|
||||
return 0;
|
||||
}
|
||||
|
||||
class HeaderParser {
|
||||
private:
|
||||
class ChunkHeader {
|
||||
uint8_t mRaw[CHUNK_HEAD_SIZE];
|
||||
|
||||
HeaderParser::ChunkHeader::ChunkSize() const {
|
||||
__coverity_tainted_data_sink__(static_cast<void*>(mRaw));
|
||||
return ((mRaw[7] << 24) | (mRaw[6] << 16) | (mRaw[5] << 8) | (mRaw[4]));
|
||||
}
|
||||
};
|
||||
};
|
||||
|
||||
void NS_DebugBreak(uint32_t aSeverity, const char* aStr, const char* aExpr,
|
||||
const char* aFile, int32_t aLine) {
|
||||
__coverity_panic__();
|
||||
}
|
||||
|
||||
static inline void Swap(uint32_t* value) {
|
||||
__coverity_tainted_data_sink__(value);
|
||||
*value = (*value >> 24) | ((*value >> 8) & 0x0000ff00) |
|
||||
((*value << 8) & 0x00ff0000) | (*value << 24);
|
||||
}
|
||||
|
||||
static uint32_t xtolong(const uint8_t* ll) {
|
||||
uint32_t value = 0;
|
||||
__coverity_tainted_data_sink__(static_cast<void*>(ll));
|
||||
return value;
|
||||
}
|
||||
|
||||
class ByteReader {
|
||||
public:
|
||||
const uint8_t* Read(size_t aCount);
|
||||
uint32_t ReadU24() {
|
||||
const uint8_t* ptr = Read(3);
|
||||
if (!ptr) {
|
||||
MOZ_ASSERT(false);
|
||||
return 0;
|
||||
}
|
||||
__coverity_tainted_data_sanitize__(static_cast<void*>(&ptr[0]));
|
||||
__coverity_tainted_data_sanitize__(static_cast<void*>(&ptr[1]));
|
||||
__coverity_tainted_data_sanitize__(static_cast<void*>(&ptr[2]));
|
||||
return ptr[0] << 16 | ptr[1] << 8 | ptr[2];
|
||||
}
|
||||
};
|
||||
|
||||
// In Bug 1248897 we've seen that Coverity thinks that json-cpp allocates
|
||||
// memmory for the strings that are used as indexes, this is wrong and this
|
||||
// model of CZString fixes this.
|
||||
|
Loading…
Reference in New Issue
Block a user