Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 21:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1759084: Tighten MachSiteManager API surface r=ahal

Browse Source 
The Mach site management has been significantly simplified
in `mach_initialize.py`, so less of the `MachSiteManager`
API is used. Privatize such now-externally-unused functions,
and no longer return unneeded values.

Differential Revision: https://phabricator.services.mozilla.com/D140854
This commit is contained in:
Mitchell Hentges 2022-03-22 19:44:12 +00:00
parent 876c137475
commit 338a1fa71c
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
python/mach/mach/site.py
View File

@ -336,7 +336,7 @@ class MachSiteManager:
source,
)
def up_to_date(self):
def _up_to_date(self):
if self._site_packages_source == SitePackagesSource.NONE:
return True
elif self._site_packages_source == SitePackagesSource.SYSTEM:
@ -359,7 +359,7 @@ class MachSiteManager:
)
def ensure(self, *, force=False):
up_to_date = self.up_to_date()
up_to_date = self._up_to_date()
if force or not up_to_date:
if Path(sys.prefix) == Path(self._metadata.prefix):
# If the Mach virtualenv is already activated, then the changes caused
@ -369,7 +369,6 @@ class MachSiteManager:
# *then* come back and run the intended command.
raise VirtualenvOutOfDateException()
self._build()
return up_to_date
def attempt_populate_optional_packages(self):
if self._site_packages_source != SitePackagesSource.VENV: