Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 16:55:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1445662 - Remove ProcessTouchVelocity from PAPZCTreeManager.ipdl. r=rhunt

Browse Source 
This function is never actually called over IPDL. It is called directly
on the concrete APZCTreeManager instance by the
AndroidDynamicToolbarAnimator code, both of which live in the
compositor. So we don't need to expose this method on IAPZCTreeManager
or over PAPZCTreeManager.

MozReview-Commit-ID: 6fEkJpDDvhl

--HG--
extra : rebase_source : cff9bb8fa43698950388b77f782b0b3fe6ec119b
This commit is contained in:
Kartikaya Gupta 2018-03-14 16:57:41 -04:00
parent 20e68959db
commit 354719495e
7 changed files with 1 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gfx/layers/apz/public/IAPZCTreeManager.h
View File

@ -190,13 +190,6 @@ public:
*/
virtual void SetLongTapEnabled(bool aTapGestureEnabled) = 0;
/**
* Process touch velocity.
* Sometimes the touch move event will have a velocity even though no scrolling
* is occurring such as when the toolbar is being hidden/shown in Fennec.
* This function can be called to have the y axis' velocity queue updated.
*/
virtual void ProcessTouchVelocity(uint32_t aTimestampMs, float aSpeedY) = 0;
// Returns whether or not a wheel event action will be (or was) performed by
// APZ. If this returns true, the event must not perform a synchronous

2
gfx/layers/apz/src/APZCTreeManager.h
View File

@ -552,7 +552,7 @@ public:
* is occurring such as when the toolbar is being hidden/shown in Fennec.
* This function can be called to have the y axis' velocity queue updated.
*/
void ProcessTouchVelocity(uint32_t aTimestampMs, float aSpeedY) override;
void ProcessTouchVelocity(uint32_t aTimestampMs, float aSpeedY);
private:
typedef bool (*GuidComparator)(const ScrollableLayerGuid&, const ScrollableLayerGuid&);

6
gfx/layers/ipc/APZCTreeManagerChild.cpp
View File

@ -221,12 +221,6 @@ APZCTreeManagerChild::SetLongTapEnabled(bool aTapGestureEnabled)
SendSetLongTapEnabled(aTapGestureEnabled);
}
void
APZCTreeManagerChild::ProcessTouchVelocity(uint32_t aTimestampMs, float aSpeedY)
{
SendProcessTouchVelocity(aTimestampMs, aSpeedY);
}
void
APZCTreeManagerChild::UpdateWheelTransaction(
LayoutDeviceIntPoint aRefPoint,

3
gfx/layers/ipc/APZCTreeManagerChild.h
View File

@ -78,9 +78,6 @@ public:
void
SetLongTapEnabled(bool aTapGestureEnabled) override;
void
ProcessTouchVelocity(uint32_t aTimestampMs, float aSpeedY) override;
void
ProcessUnhandledEvent(
LayoutDeviceIntPoint* aRefPoint,

9
gfx/layers/ipc/APZCTreeManagerParent.cpp
View File

@ -339,15 +339,6 @@ APZCTreeManagerParent::RecvSetLongTapEnabled(const bool& aTapGestureEnabled)
return IPC_OK();
}
mozilla::ipc::IPCResult
APZCTreeManagerParent::RecvProcessTouchVelocity(
const uint32_t& aTimestampMs,
const float& aSpeedY)
{
mTreeManager->ProcessTouchVelocity(aTimestampMs, aSpeedY);
return IPC_OK();
}
mozilla::ipc::IPCResult
APZCTreeManagerParent::RecvUpdateWheelTransaction(
const LayoutDeviceIntPoint& aRefPoint,

5
gfx/layers/ipc/APZCTreeManagerParent.h
View File

@ -134,11 +134,6 @@ public:
mozilla::ipc::IPCResult
RecvSetLongTapEnabled(const bool& aTapGestureEnabled) override;
mozilla::ipc::IPCResult
RecvProcessTouchVelocity(
const uint32_t& aTimestampMs,
const float& aSpeedY) override;
mozilla::ipc::IPCResult
RecvUpdateWheelTransaction(
const LayoutDeviceIntPoint& aRefPoint,

2
gfx/layers/ipc/PAPZCTreeManager.ipdl
View File

@ -85,8 +85,6 @@ parent:
async SetLongTapEnabled(bool aTapGestureEnabled);
async ProcessTouchVelocity(uint32_t aTimestampMs, float aSpeedY);
// The following messages are used to
// implement the ReceiveInputEvent methods