diff --git a/dom/ipc/ContentParent.cpp b/dom/ipc/ContentParent.cpp index 02788302610a..773db27200c7 100644 --- a/dom/ipc/ContentParent.cpp +++ b/dom/ipc/ContentParent.cpp @@ -3605,7 +3605,7 @@ PExternalHelperAppParent* ContentParent::AllocPExternalHelperAppParent( const int64_t& aContentLength, const bool& aWasFileChannel, const OptionalURIParams& aReferrer, PBrowserParent* aBrowser) { ExternalHelperAppParent* parent = new ExternalHelperAppParent( - uri, aLoadInfoArgs, aContentLength, aWasFileChannel, aContentDisposition, + uri, aContentLength, aWasFileChannel, aContentDisposition, aContentDispositionHint, aContentDispositionFilename); parent->AddRef(); return parent; @@ -3626,7 +3626,8 @@ mozilla::ipc::IPCResult ContentParent::RecvPExternalHelperAppConstructor( const nsString& aContentDispositionFilename, const bool& aForceSave, const int64_t& aContentLength, const bool& aWasFileChannel, const OptionalURIParams& aReferrer, PBrowserParent* aBrowser) { - actor->Init(aMimeContentType, aForceSave, aReferrer, aBrowser); + static_cast(actor)->Init( + loadInfoArgs, aMimeContentType, aForceSave, aReferrer, aBrowser); return IPC_OK(); } diff --git a/uriloader/exthandler/ExternalHelperAppParent.cpp b/uriloader/exthandler/ExternalHelperAppParent.cpp index 097c6142fc46..7f6ecad8ce30 100644 --- a/uriloader/exthandler/ExternalHelperAppParent.cpp +++ b/uriloader/exthandler/ExternalHelperAppParent.cpp @@ -34,7 +34,6 @@ NS_IMPL_ISUPPORTS_INHERITED(ExternalHelperAppParent, nsHashPropertyBag, ExternalHelperAppParent::ExternalHelperAppParent( const OptionalURIParams& uri, - const mozilla::net::OptionalLoadInfoArgs& aLoadInfoArgs, const int64_t& aContentLength, const bool& aWasFileChannel, const nsCString& aContentDispositionHeader, const uint32_t& aContentDispositionHint, @@ -61,8 +60,6 @@ ExternalHelperAppParent::ExternalHelperAppParent( mContentDisposition = aContentDispositionHint; mContentDispositionFilename = aContentDispositionFilename; } - mozilla::ipc::LoadInfoArgsToLoadInfo(aLoadInfoArgs, - getter_AddRefs(mLoadInfo)); } already_AddRefed GetWindowFromTabParent( @@ -88,10 +85,14 @@ void UpdateContentContext(nsIStreamListener* aListener, static_cast(aListener)->SetContentContext(window); } -void ExternalHelperAppParent::Init(const nsCString& aMimeContentType, +void ExternalHelperAppParent::Init(const mozilla::net::OptionalLoadInfoArgs& aLoadInfoArgs, + const nsCString& aMimeContentType, const bool& aForceSave, const OptionalURIParams& aReferrer, PBrowserParent* aBrowser) { + mozilla::ipc::LoadInfoArgsToLoadInfo(aLoadInfoArgs, + getter_AddRefs(mLoadInfo)); + nsCOMPtr helperAppService = do_GetService(NS_EXTERNALHELPERAPPSERVICE_CONTRACTID); NS_ASSERTION(helperAppService, "No Helper App Service!"); diff --git a/uriloader/exthandler/ExternalHelperAppParent.h b/uriloader/exthandler/ExternalHelperAppParent.h index f68ed3d421a1..c2dc9fd5ccb9 100644 --- a/uriloader/exthandler/ExternalHelperAppParent.h +++ b/uriloader/exthandler/ExternalHelperAppParent.h @@ -86,12 +86,12 @@ class ExternalHelperAppParent ExternalHelperAppParent( const OptionalURIParams& uri, - const mozilla::net::OptionalLoadInfoArgs& aLoadInfoArgs, const int64_t& contentLength, const bool& wasFileChannel, const nsCString& aContentDispositionHeader, const uint32_t& aContentDispositionHint, const nsString& aContentDispositionFilename); - void Init(const nsCString& aMimeContentType, const bool& aForceSave, + void Init(const mozilla::net::OptionalLoadInfoArgs& aLoadInfoArgs, + const nsCString& aMimeContentType, const bool& aForceSave, const OptionalURIParams& aReferrer, PBrowserParent* aBrowser); protected: