Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 12:51:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1732947: Venv is out-of-date if "virtualenv" package is changed r=ahal

Browse Source 
The `virtualenv` package version defines what `pip`/`setuptools`/`wheel`
that is installed in our venvs. Since we depend on the behaviour of
these tools, we should consider our venvs out-of-date if they weren't
created with the current `virtualenv` version.

Differential Revision: https://phabricator.services.mozilla.com/D126818
This commit is contained in:
Mitchell Hentges 2021-09-29 15:16:39 +00:00
parent be7e494d0c
commit 35d35bc9ff
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
python/mach/mach/virtualenv/__init__.py
View File

@ -176,10 +176,22 @@ class VirtualenvManager(VirtualenvHelper):
return False
env_requirements = self._requirements()
deps = [__file__] + env_requirements.requirements_paths
# Modifications to our package dependency list or to this file mean the
# virtualenv should be rebuilt.
virtualenv_package = os.path.join(
self.topsrcdir,
"third_party",
"python",
"virtualenv",
"virtualenv",
"version.py",
)
deps = [__file__, virtualenv_package] + env_requirements.requirements_paths
# Modifications to any of the following files mean the virtualenv should be
# rebuilt:
# * This file
# * The `virtualenv` package
# * Any of our requirements manifest files
activate_mtime = os.path.getmtime(self.activate_path)
dep_mtime = max(os.path.getmtime(p) for p in deps)
if dep_mtime > activate_mtime: