Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-28 03:18:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 945585 - Add shouldDelete to nsDocument::Release. r=mccr8

Browse Source
This commit is contained in:
Olli Pettay 2013-12-23 09:10:46 -05:00
parent 2207180e99
commit 35f59dc30c
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
content/base/src/nsDocument.cpp
View File

@ -1639,7 +1639,8 @@ nsDocument::Release()
NS_PRECONDITION(0 != mRefCnt, "dup release");
NS_ASSERT_OWNINGTHREAD(nsDocument);
nsISupports* base = NS_CYCLE_COLLECTION_CLASSNAME(nsDocument)::Upcast(this);
nsrefcnt count = mRefCnt.decr(base);
bool shouldDelete = false;
nsrefcnt count = mRefCnt.decr(base, &shouldDelete);
NS_LOG_RELEASE(this, count, "nsDocument");
if (count == 0) {
if (mStackRefCnt && !mNeedsReleaseAfterStackRefCntRelease) {
@ -1647,8 +1648,13 @@ nsDocument::Release()
NS_ADDREF_THIS();
return mRefCnt.get();
}
NS_ASSERT_OWNINGTHREAD(nsDocument);
mRefCnt.incr();
nsNodeUtils::LastRelease(this);
mRefCnt.decr(base);
if (shouldDelete) {
mRefCnt.stabilizeForDeletion();
DeleteCycleCollectable();
}
}
return count;
}