Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-19 07:26:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1809360 - Have this test check against the correct scroll position. r=settings-reviewers,Gijs

Browse Source 
The test is checking whether the preferences page has ever been scrolled at
all for any reason, which means the scroll that happens when the setting under
test is focused is causing the failure. But we're really only interested in
what happens when the setting is toggled, not focused, so we should save the
scroll position right before the toggle happens and compare the final position
against that, not just always against zero.

Differential Revision: https://phabricator.services.mozilla.com/D170087
This commit is contained in:
Molly Howell 2023-02-16 18:30:53 +00:00
parent e4f60f12db
commit 3687ba7c9e
1 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
browser/components/preferences/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.js
View File

@ -16,21 +16,24 @@ add_task(async function() {
// Test button
let button = doc.getElementById("button");
button.focus();
let initialScrollTop = container.scrollTop;
EventUtils.sendString(" ");
await checkPageScrolling(container, "button");
await checkPageScrolling(container, "button", initialScrollTop);
// Test checkbox
let checkbox = doc.getElementById("checkbox");
checkbox.focus();
initialScrollTop = container.scrollTop;
EventUtils.sendString(" ");
ok(checkbox.checked, "Checkbox is checked");
await checkPageScrolling(container, "checkbox");
await checkPageScrolling(container, "checkbox", initialScrollTop);
// Test radio
let radiogroup = doc.getElementById("radiogroup");
radiogroup.focus();
initialScrollTop = container.scrollTop;
EventUtils.sendString(" ");
await checkPageScrolling(container, "radio");
await checkPageScrolling(container, "radio", initialScrollTop);
});
await BrowserTestUtils.withNewTab(
@ -42,6 +45,7 @@ add_task(async function() {
// Test search
let engineList = doc.getElementById("engineList");
engineList.focus();
let initialScrollTop = container.scrollTop;
EventUtils.sendString(" ");
is(
engineList.view.selection.currentIndex,
@ -49,7 +53,11 @@ add_task(async function() {
"Search engineList is selected"
);
EventUtils.sendString(" ");
await checkPageScrolling(container, "search engineList");
await checkPageScrolling(
container,
"search engineList",
initialScrollTop
);
}
);
@ -81,19 +89,24 @@ add_task(async function() {
let tabsToggle = doc.getElementById("tabsToggle");
tabsToggle.focus();
let initialScrollTop = doc.documentElement.scrollTop;
EventUtils.sendString(" ");
await checkPageScrolling(doc.documentElement, "session restore");
await checkPageScrolling(
doc.documentElement,
"session restore",
initialScrollTop
);
gBrowser.removeCurrentTab();
finish();
});
function checkPageScrolling(container, type) {
function checkPageScrolling(container, type, initialScrollTop = 0) {
return new Promise(resolve => {
setTimeout(() => {
is(
container.scrollTop,
0,
initialScrollTop,
"Page should not scroll when " + type + " flipped"
);
resolve();