Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 12:51:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1849273 - Remove the explicit --enable-crashreporter in mozconfig.common. r=firefox-build-system-reviewers,ahochheiden

Browse Source 
It has been enabled by default on the relevant platforms essentially
forever, so it doesn't need to be explicitly enabled.

As such, since --enable-crashreporter is not really a useful thing to
point at to wrt build options, we remove its mention from the
configuring build options doc.

Differential Revision: https://phabricator.services.mozilla.com/D186513
This commit is contained in:
Mike Hommey 2023-08-23 19:07:08 +00:00
parent a1b004c23a
commit 368daa89f8
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
build/mozconfig.common
View File

@ -16,8 +16,6 @@ fi
mk_add_options AUTOCLOBBER=1
ac_add_options --enable-crashreporter
ac_add_options --enable-js-shell
. "$topsrcdir/build/mozconfig.automation"

8
docs/setup/configuring_build_options.rst
View File

@ -304,14 +304,6 @@ Other Options
to clobber and continue with the build instead of asking the user to
manually clobber and exiting.
``ac_add_options --enable-crashreporter``
This enables the machinery that allows Firefox to write out a
`minidump <https://docs.microsoft.com/en-us/windows/desktop/Debug/minidump-files>`__
files when crashing as well as the tools to process and submit crash
reports to Mozilla. After enabling the crash reporter in your local
build, you will need to run mach with the --enable-crash-reporter
(note the extra dash) to enable it at runtime, like so:
``./mach run --enable-crash-reporter``
``ac_add_options --enable-warnings-as-errors``
This makes compiler warnings into errors which fail the build. This
can be useful since certain warnings coincide with reviewbot lints