Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-29 07:42:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

coverity-found potential use-after-free in testcases (bug 334541). r=bsmedberg

Browse Source
This commit is contained in:
dveditz%cruzio.com 2007-01-26 02:50:18 +00:00
parent c65cea94eb
commit 369c3dbf2e
2 changed files with 12 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
xpcom/tests/TestCOMPtr.cpp
View File

@ -155,24 +155,21 @@ IFoo::AddRef()
nsrefcnt
IFoo::Release()
{
int wrap_message = (refcount_ == 1);
if ( wrap_message )
int newcount = --refcount_;
if ( newcount == 0 )
printf(">>");
--refcount_;
printf("IFoo@%p::Release(), refcount --> %d\n",
STATIC_CAST(void*, this), refcount_);
if ( !refcount_ )
if ( newcount == 0 )
{
printf(" delete IFoo@%p\n", STATIC_CAST(void*, this));
printf("<<IFoo@%p::Release()\n", STATIC_CAST(void*, this));
delete this;
}
if ( wrap_message )
printf("<<IFoo@%p::Release()\n", STATIC_CAST(void*, this));
return refcount_;
return newcount;
}
nsresult

15
xpcom/tests/TestHashtables.cpp
View File

@ -288,24 +288,21 @@ IFoo::AddRef()
nsrefcnt
IFoo::Release()
{
int wrap_message = (refcount_ == 1);
if ( wrap_message )
int newcount = --refcount_;
if ( newcount == 0 )
printf(">>");
--refcount_;
printf("IFoo@%p::Release(), refcount --> %d\n",
NS_STATIC_CAST(void*, this), refcount_);
if ( !refcount_ )
if ( newcount == 0 )
{
printf(" delete IFoo@%p\n", NS_STATIC_CAST(void*, this));
printf("<<IFoo@%p::Release()\n", NS_STATIC_CAST(void*, this));
delete this;
}
if ( wrap_message )
printf(" delete IFoo@%p\n", NS_STATIC_CAST(void*, this));
return refcount_;
return newcount;
}
nsresult