Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-25 20:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1864459 - WorkerPrivate::IsEligibleForCC should consider if there are any pending events. r=asuth

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D193984
This commit is contained in:
Eden Chuang 2023-11-20 10:04:07 +00:00
parent acb150212e
commit 369c69cb51
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
dom/workers/WorkerPrivate.cpp
View File

@ -4334,7 +4334,13 @@ bool WorkerPrivate::IsEligibleForCC() {
return true;
}
bool HasShutdownTasks = !mShutdownTasks.IsEmpty();
bool hasShutdownTasks = !mShutdownTasks.IsEmpty();
bool hasPendingEvents = false;
if (mThread) {
hasPendingEvents =
NS_SUCCEEDED(mThread->HasPendingEvents(&hasPendingEvents)) &&
hasPendingEvents;
}
LOGV(("mMainThreadEventTarget: %s",
mMainThreadEventTarget->IsEmpty() ? "empty" : "non-empty"));
@ -4343,12 +4349,13 @@ bool WorkerPrivate::IsEligibleForCC() {
LOGV(("mMainThreadDebuggerEventTarget: %s",
mMainThreadDebuggeeEventTarget->IsEmpty() ? "empty" : "non-empty"));
LOGV(("mCCFlagSaysEligible: %s", mCCFlagSaysEligible ? "true" : "false"));
LOGV(("HasShutdownTasks: %s", HasShutdownTasks ? "true" : "false"));
LOGV(("hasShutdownTasks: %s", hasShutdownTasks ? "true" : "false"));
LOGV(("hasPendingEvents: %s", hasPendingEvents ? "true" : "false"));
return mMainThreadEventTarget->IsEmpty() &&
mMainThreadEventTargetForMessaging->IsEmpty() &&
mMainThreadDebuggeeEventTarget->IsEmpty() && mCCFlagSaysEligible &&
!HasShutdownTasks;
!hasShutdownTasks && !hasPendingEvents;
}
void WorkerPrivate::CancelAllTimeouts() {