Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-27 04:05:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1243595 - Add session measurements to core ping builder & update version. r=ahunt

Browse Source 
MozReview-Commit-ID: Erwd83PZ57k

--HG--
extra : rebase_source : 7279a86fc027a665f824b647fd8d8540d2b906f6
This commit is contained in:
Michael Comella 2016-05-17 17:13:35 -07:00
parent cd62b5cf48
commit 36ea09ba64
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
mobile/android/base/java/org/mozilla/gecko/telemetry/pingbuilders/TelemetryCorePingBuilder.java
View File

@ -42,7 +42,7 @@ public class TelemetryCorePingBuilder extends TelemetryPingBuilder {
private static final String LOGTAG = StringUtils.safeSubstring(TelemetryCorePingBuilder.class.getSimpleName(), 0, 23);
private static final String NAME = "core";
private static final int VERSION_VALUE = 6; // For version history, see toolkit/components/telemetry/docs/core-ping.rst
private static final int VERSION_VALUE = 7; // For version history, see toolkit/components/telemetry/docs/core-ping.rst
private static final String OS_VALUE = "Android";
private static final String ARCHITECTURE = "arch";
@ -58,6 +58,8 @@ public class TelemetryCorePingBuilder extends TelemetryPingBuilder {
private static final String PROFILE_CREATION_DATE = "profileDate";
private static final String SEARCH_COUNTS = "searches";
private static final String SEQ = "seq";
private static final String SESSION_COUNT = "sessions";
private static final String SESSION_DURATION = "durations";
private static final String TIMEZONE_OFFSET = "tz";
private static final String VERSION_ATTR = "v";
@ -175,6 +177,26 @@ public class TelemetryCorePingBuilder extends TelemetryPingBuilder {
return this;
}
public TelemetryCorePingBuilder setSessionCount(final int sessionCount) {
if (sessionCount < 0) {
// Since this is an increasing value, it's possible we can overflow into negative values and get into a
// crash loop so we don't crash on invalid arg - we can investigate if we see negative values on the server.
Log.w(LOGTAG, "Expected positive session count. Received: " + sessionCount);
}
payload.put(SESSION_COUNT, sessionCount);
return this;
}
public TelemetryCorePingBuilder setSessionDuration(final long sessionDuration) {
if (sessionDuration < 0) {
// Since this is an increasing value, it's possible we can overflow into negative values and get into a
// crash loop so we don't crash on invalid arg - we can investigate if we see negative values on the server.
Log.w(LOGTAG, "Expected positive session duration. Received: " + sessionDuration);
}
payload.put(SESSION_DURATION, sessionDuration);
return this;
}
/**
* Gets the sequence number from shared preferences and increments it in the prefs. This method
* is not thread safe.