Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 21:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1642526 - Force the macOS scrollthumbs to be drawn via the custom drawing codepath. r=mstange

Browse Source 
The default drawing codepath requests the OS to draw it, but the OS seems to
ignore the scaling factor of the transform. So when drawing scrollbars after
APZ-zooming, the scrollthumbs appear abnormally thin. This patch forces us into
the custom drawing codepath which gets scaled properly.

Differential Revision: https://phabricator.services.mozilla.com/D92677
This commit is contained in:
Kartikaya Gupta 2020-10-06 21:18:41 +00:00
parent 9abf9516ff
commit 36fe42d67a
4 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
widget/cocoa/nsNativeThemeCocoa.mm
View File

@ -2390,6 +2390,16 @@ nsNativeThemeCocoa::ScrollbarParams nsNativeThemeCocoa::ComputeScrollbarParams(n
params.faceColor = colors.thumb.CalcColor(*style);
}
}
// With APZ zooming, we need to be able to draw scrollbars manually because
// the native CG drawing doesn't apply our desired scale. The easiest way to
// do this is set the custom flag with the default scrollbar colors.
if (!params.custom) {
params.custom = true;
params.trackColor = NS_RGBA(250, 250, 250, 255);
params.faceColor = NS_RGBA(194, 194, 194, 255);
}
return params;
}

1
widget/reftests/reftest.list
View File

@ -3,3 +3,4 @@ fuzzy-if(Android,0-17,0-1120) fuzzy-if(webrender,0-8,0-480) == meter-native-styl
skip-if(!cocoaWidget) == meter-vertical-native-style.html meter-vertical-native-style-ref.html # dithering
== meter-fallback-default-style.html meter-fallback-default-style-ref.html
load 664925.xhtml
pref(apz.allow_zooming,true) pref(ui.useOverlayScrollbars,0) skip-if(!cocoaWidget) == scaled-scrollbar.html scaled-scrollbar-ref.html

6
widget/reftests/scaled-scrollbar-ref.html Normal file
View File

@ -0,0 +1,6 @@
<!DOCTYPE html>
<html reftest-resolution="2.0">
<div style="scrollbar-color: rgb(194,194,194) rgb(250,250,250); overflow: scroll; width: 300px; height: 300px">
<div style="width: 1000px; height: 1000px"></div>
</div>
</html>

6
widget/reftests/scaled-scrollbar.html Normal file
View File

@ -0,0 +1,6 @@
<!DOCTYPE html>
<html reftest-resolution="2.0">
<div style="overflow: scroll; width: 300px; height: 300px">
<div style="width: 1000px; height: 1000px"></div>
</div>
</html>