Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-17 06:09:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1928769 - Stop holding a mutex across gIPCLaunchThread shutdown, r=ipc-reviewers,jld

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D227761
This commit is contained in:
Nika Layzell 2024-11-18 17:24:16 +00:00
parent cfd4996e68
commit 372214f2e1
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ipc/glue/GeckoChildProcessHost.cpp
View File

@ -982,13 +982,14 @@ NS_IMETHODIMP
IPCLaunchThreadObserver::Observe(nsISupports* aSubject, const char* aTopic,
const char16_t* aData) {
MOZ_RELEASE_ASSERT(strcmp(aTopic, "xpcom-shutdown-threads") == 0);
StaticMutexAutoLock lock(gIPCLaunchThreadMutex);
nsresult rv = NS_OK;
if (gIPCLaunchThread) {
rv = gIPCLaunchThread->Shutdown();
gIPCLaunchThread = nullptr;
nsCOMPtr<nsIThread> thread;
{
StaticMutexAutoLock lock(gIPCLaunchThreadMutex);
thread = gIPCLaunchThread.forget();
}
nsresult rv = thread ? thread->Shutdown() : NS_OK;
mozilla::Unused << NS_WARN_IF(NS_FAILED(rv));
return rv;
}