Bug 1231975 - Part 7: Disable trickle for the NAT tests, since trickle delays can cause lower priority pairs to get selected. r=drno

MozReview-Commit-ID: GaqZQxJ7g2E

--HG--
extra : rebase_source : 576924d843f24b943a7f4f9ead4cd5b83c3b62d1
This commit is contained in:
Byron Campen [:bwc] 2016-04-28 09:47:08 -05:00
parent c790fde040
commit 37a184c8eb
3 changed files with 16 additions and 0 deletions

View File

@ -1,6 +1,7 @@
<!DOCTYPE HTML>
<html>
<head>
<script type="application/javascript" src="nonTrickleIce.js"></script>
<script type="application/javascript" src="pc.js"></script>
</head>
<body>
@ -27,6 +28,12 @@
// relay.
options.turn_disabled_local = true;
test = new PeerConnectionTest(options);
// Make sure we don't end up choosing the wrong thing due to delays in
// trickle. Once we are willing to accept trickle after ICE success, we
// can maybe wait a bit to allow things to stabilize.
// TODO(bug 1238249)
makeOffererNonTrickle(test.chain);
makeAnswererNonTrickle(test.chain);
test.setMediaConstraints([{audio: true}], [{audio: true}]);
test.run();
})

View File

@ -24,6 +24,8 @@
options = options || {};
options.expectedLocalCandidateType = "relayed-tcp";
options.expectedRemoteCandidateType = "relayed-tcp";
// No reason to wait for gathering to complete like the other NAT tests,
// since relayed-tcp is the only thing that can work.
test = new PeerConnectionTest(options);
test.setMediaConstraints([{audio: true}], [{audio: true}]);
test.run();

View File

@ -1,6 +1,7 @@
<!DOCTYPE HTML>
<html>
<head>
<script type="application/javascript" src="nonTrickleIce.js"></script>
<script type="application/javascript" src="pc.js"></script>
</head>
<body>
@ -24,6 +25,12 @@
options.expectedLocalCandidateType = "serverreflexive";
options.expectedRemoteCandidateType = "serverreflexive";
test = new PeerConnectionTest(options);
// Make sure we don't end up choosing the wrong thing due to delays in
// trickle. Once we are willing to accept trickle after ICE success, we
// can maybe wait a bit to allow things to stabilize.
// TODO(bug 1238249)
makeOffererNonTrickle(test.chain);
makeAnswererNonTrickle(test.chain);
test.setMediaConstraints([{audio: true}], [{audio: true}]);
test.run();
})