Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 05:41:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1640274 - Remove the unused TrackOptimizations profiler; r=gerald

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D76854
This commit is contained in:
Greg Tatum 2020-05-27 22:08:49 +00:00
parent ca8ec92461
commit 3802fc82a4
9 changed files with 16 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
devtools/client/performance-new/utils.js
View File

@ -349,12 +349,6 @@ const featureDescriptions = [
value: "seqstyle",
title: "Disable parallel traversal in styling.",
},
{
name: "JIT Optimizations",
value: "trackopts",
title: "Track JIT optimizations in the JS engine.",
experimental: true,
},
{
name: "TaskTracer",
value: "tasktracer",

1
mozglue/baseprofiler/core/platform.cpp
View File

@ -211,7 +211,6 @@ static uint32_t AvailableFeatures() {
ProfilerFeature::ClearStackWalk(features);
#endif
ProfilerFeature::ClearTaskTracer(features);
ProfilerFeature::ClearTrackOptimizations(features);
ProfilerFeature::ClearJSTracer(features);
return features;

5
mozglue/baseprofiler/core/platform.h
View File

@ -115,9 +115,8 @@ void profiler_get_profile_json_into_lazily_allocated_buffer(
// Flags to conveniently track various JS instrumentations.
enum class JSInstrumentationFlags {
StackSampling = 0x1,
TrackOptimizations = 0x2,
TraceLogging = 0x4,
Allocations = 0x8
TraceLogging = 0x2,
Allocations = 0x4,
};
// Record an exit profile from a child process.

15
mozglue/baseprofiler/public/BaseProfiler.h
View File

@ -139,26 +139,23 @@ class SpliceableJSONWriter;
\
MACRO(11, "threads", Threads, "Profile the registered secondary threads") \
\
MACRO(12, "trackopts", TrackOptimizations, \
"Have the JavaScript engine track JIT optimizations") \
MACRO(12, "jstracer", JSTracer, "Enable tracing of the JavaScript engine") \
\
MACRO(13, "jstracer", JSTracer, "Enable tracing of the JavaScript engine") \
\
MACRO(14, "jsallocations", JSAllocations, \
MACRO(13, "jsallocations", JSAllocations, \
"Have the JavaScript engine track allocations") \
\
MACRO(15, "nostacksampling", NoStackSampling, \
MACRO(14, "nostacksampling", NoStackSampling, \
"Disable all stack sampling: Cancels \"js\", \"leaf\", " \
"\"stackwalk\" and labels") \
\
MACRO(16, "preferencereads", PreferenceReads, \
MACRO(15, "preferencereads", PreferenceReads, \
"Track when preferences are read") \
\
MACRO(17, "nativeallocations", NativeAllocations, \
MACRO(16, "nativeallocations", NativeAllocations, \
"Collect the stacks from a smaller subset of all native " \
"allocations, biasing towards collecting larger allocations") \
\
MACRO(18, "ipcmessages", IPCMessages, \
MACRO(17, "ipcmessages", IPCMessages, \
"Have the IPC layer track cross-process messages")
struct ProfilerFeature {

1
toolkit/components/extensions/schemas/geckoProfiler.json
View File

@ -33,7 +33,6 @@
"stackwalk",
"tasktracer",
"threads",
"trackopts",
"jstracer",
"jsallocations",
"nostacksampling",

4
tools/profiler/core/RegisteredThread.h
View File

@ -324,10 +324,6 @@ class RegisteredThread final {
uint32_t mJSFlags;
bool TrackOptimizationsEnabled() {
return mJSFlags & uint32_t(JSInstrumentationFlags::TrackOptimizations);
}
bool JSTracerEnabled() {
return mJSFlags & uint32_t(JSInstrumentationFlags::TraceLogging);
}

3
tools/profiler/core/platform.cpp
View File

@ -984,9 +984,6 @@ class ActivePS {
uint32_t Flags = 0;
Flags |=
FeatureJS(aLock) ? uint32_t(JSInstrumentationFlags::StackSampling) : 0;
Flags |= FeatureTrackOptimizations(aLock)
? uint32_t(JSInstrumentationFlags::TrackOptimizations)
: 0;
Flags |= FeatureJSTracer(aLock)
? uint32_t(JSInstrumentationFlags::TraceLogging)
: 0;

5
tools/profiler/core/platform.h
View File

@ -95,9 +95,8 @@ void profiler_get_profile_json_into_lazily_allocated_buffer(
// Flags to conveniently track various JS instrumentations.
enum class JSInstrumentationFlags {
StackSampling = 0x1,
TrackOptimizations = 0x2,
TraceLogging = 0x4,
Allocations = 0x8
TraceLogging = 0x2,
Allocations = 0x4,
};
// Record an exit profile from a child process.

15
tools/profiler/public/GeckoProfiler.h
View File

@ -177,26 +177,23 @@ class Vector;
\
MACRO(11, "threads", Threads, "Profile the registered secondary threads") \
\
MACRO(12, "trackopts", TrackOptimizations, \
"Have the JavaScript engine track JIT optimizations") \
MACRO(12, "jstracer", JSTracer, "Enable tracing of the JavaScript engine") \
\
MACRO(13, "jstracer", JSTracer, "Enable tracing of the JavaScript engine") \
\
MACRO(14, "jsallocations", JSAllocations, \
MACRO(13, "jsallocations", JSAllocations, \
"Have the JavaScript engine track allocations") \
\
MACRO(15, "nostacksampling", NoStackSampling, \
MACRO(14, "nostacksampling", NoStackSampling, \
"Disable all stack sampling: Cancels \"js\", \"leaf\", " \
"\"stackwalk\" and labels") \
\
MACRO(16, "preferencereads", PreferenceReads, \
MACRO(15, "preferencereads", PreferenceReads, \
"Track when preferences are read") \
\
MACRO(17, "nativeallocations", NativeAllocations, \
MACRO(16, "nativeallocations", NativeAllocations, \
"Collect the stacks from a smaller subset of all native " \
"allocations, biasing towards collecting larger allocations") \
\
MACRO(18, "ipcmessages", IPCMessages, \
MACRO(17, "ipcmessages", IPCMessages, \
"Have the IPC layer track cross-process messages")
struct ProfilerFeature {