Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 11:55:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1728565 part 4 - Remove support for objects with fixed data from the generic allocation path. r=sfink

Browse Source 
Depends on D124326

Differential Revision: https://phabricator.services.mozilla.com/D124327
This commit is contained in:
Jan de Mooij 2021-09-06 13:54:30 +00:00
parent d14119d3e8
commit 39e95288ea
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/src/vm/JSObject-inl.h
View File

@ -132,6 +132,7 @@ inline bool JSObject::isUnqualifiedVarObj() const {
namespace js {
#ifdef DEBUG
inline bool ClassCanHaveFixedData(const JSClass* clasp) {
// Normally, the number of fixed slots given an object is the maximum
// permitted for its size class. For array buffers and non-shared typed
@ -141,6 +142,7 @@ inline bool ClassCanHaveFixedData(const JSClass* clasp) {
return !clasp->isNativeObject() || clasp == &js::ArrayBufferObject::class_ ||
js::IsTypedArrayClass(clasp);
}
#endif
class MOZ_RAII AutoSuppressAllocationMetadataBuilder {
JS::Zone* zone;

11
js/src/vm/JSObject.cpp
View File

@ -740,13 +740,12 @@ static inline NativeObject* NewObject(JSContext* cx, Handle<TaggedProto> proto,
MOZ_ASSERT(clasp != &PlainObject::class_);
MOZ_ASSERT(!clasp->isJSFunction());
// For objects which can have fixed data following the object, only use
// enough fixed slots to cover the number of reserved slots in the object,
// regardless of the allocation kind specified.
size_t nfixed = ClassCanHaveFixedData(clasp)
? GetGCKindSlots(gc::GetGCObjectKind(clasp))
: GetGCKindSlots(kind);
// Computing nfixed based on the AllocKind isn't right for objects which can
// store fixed data inline (TypedArrays and ArrayBuffers) so for simplicity
// and performance reasons we don't support such objects here.
MOZ_ASSERT(!ClassCanHaveFixedData(clasp));
size_t nfixed = GetGCKindSlots(kind);
RootedShape shape(
cx, SharedShape::getInitialShape(cx, clasp, cx->realm(), proto, nfixed,
objectFlags));