Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-18 06:45:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixes bug 253394 "nsFtpState::S_user leaks user & password string" patch by jon@rekai.net r+sr=darin

Browse Source
This commit is contained in:
darin%meer.net 2004-12-05 19:20:19 +00:00
parent 5cbc9ce5d3
commit 3a069e62e4
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp
View File

@ -1025,7 +1025,7 @@ nsFtpState::S_user() {
} else {
if (mUsername.IsEmpty()) {
if (!mAuthPrompter) return NS_ERROR_NOT_INITIALIZED;
PRUnichar *user = nsnull, *passwd = nsnull;
nsXPIDLString user, passwd;
PRBool retval;
nsCAutoString prePath;
rv = mURL->GetPrePath(prePath);
@ -1048,8 +1048,8 @@ nsFtpState::S_user() {
formatedString,
prePathU.get(),
nsIAuthPrompt::SAVE_PASSWORD_PERMANENTLY,
&user,
&passwd,
getter_Copies(user),
getter_Copies(passwd),
&retval);
// if the user canceled or didn't supply a username we want to fail
@ -1125,7 +1125,7 @@ nsFtpState::S_pass() {
if (mPassword.IsEmpty() || mRetryPass) {
if (!mAuthPrompter) return NS_ERROR_NOT_INITIALIZED;
PRUnichar *passwd = nsnull;
nsXPIDLString passwd;
PRBool retval;
nsCAutoString prePath;
@ -1150,7 +1150,7 @@ nsFtpState::S_pass() {
formatedString,
prePathU.get(),
nsIAuthPrompt::SAVE_PASSWORD_PERMANENTLY,
&passwd, &retval);
getter_Copies(passwd), &retval);
// we want to fail if the user canceled. Note here that if they want
// a blank password, we will pass it along.