Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-27 04:38:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1691578 - part2 : remove unnecessary operation of removing ffmpeg error flag. r=bryce

Browse Source 
This operation is actually meaningless, because at the time we call `CreateRddPDMs()`, the PDMFactory is just created. [PDMFactory()->CreatePDMs()->CreateRddPDMs()]

So that is impossible that we've failed to load ffmpeg before, so no need to subtract the `FFmpegFailedToLoad` flag.

Differential Revision: https://phabricator.services.mozilla.com/D104472
This commit is contained in:
alwu 2021-02-25 18:07:05 +00:00
parent e85012fb68
commit 3a4f0f96c7
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dom/media/platforms/PDMFactory.cpp
View File

@ -473,8 +473,6 @@ void PDMFactory::CreateRddPDMs() {
StaticPrefs::media_rdd_ffmpeg_enabled() &&
!CreateAndStartupPDM<FFmpegRuntimeLinker>()) {
mFailureFlags += DecoderDoctorDiagnostics::Flags::FFmpegFailedToLoad;
} else {
mFailureFlags -= DecoderDoctorDiagnostics::Flags::FFmpegFailedToLoad;
}
#endif
CreateAndStartupPDM<AgnosticDecoderModule>();