From 3a4f0f96c784a78963912e242fddf29e5fb155ac Mon Sep 17 00:00:00 2001
From: alwu <alwu@mozilla.com>
Date: Thu, 25 Feb 2021 18:07:05 +0000
Subject: [PATCH] Bug 1691578 - part2 : remove unnecessary operation of
 removing ffmpeg error flag. r=bryce

This operation is actually meaningless, because at the time we call `CreateRddPDMs()`, the PDMFactory is just created. [PDMFactory()->CreatePDMs()->CreateRddPDMs()]

So that is impossible that we've failed to load ffmpeg before, so no need to subtract the `FFmpegFailedToLoad` flag.

Differential Revision: https://phabricator.services.mozilla.com/D104472
---
 dom/media/platforms/PDMFactory.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/dom/media/platforms/PDMFactory.cpp b/dom/media/platforms/PDMFactory.cpp
index ee8b0a1ee0c4..bf7e1dce4f32 100644
--- a/dom/media/platforms/PDMFactory.cpp
+++ b/dom/media/platforms/PDMFactory.cpp
@@ -473,8 +473,6 @@ void PDMFactory::CreateRddPDMs() {
       StaticPrefs::media_rdd_ffmpeg_enabled() &&
       !CreateAndStartupPDM<FFmpegRuntimeLinker>()) {
     mFailureFlags += DecoderDoctorDiagnostics::Flags::FFmpegFailedToLoad;
-  } else {
-    mFailureFlags -= DecoderDoctorDiagnostics::Flags::FFmpegFailedToLoad;
   }
 #endif
   CreateAndStartupPDM<AgnosticDecoderModule>();