Bug 1349695 - Part 3: Convert manual addrefs in txNodeSorter::sortNodeSet. r=peterv

Use RefPtr::forget to avoid an AddRef/Release pair when returning.
This commit is contained in:
Eric Rahm 2017-04-10 14:04:27 -07:00
parent 7a68f28ccb
commit 3ab41f111b

View File

@ -127,7 +127,8 @@ txNodeSorter::sortNodeSet(txNodeSet* aNodes, txExecutionState* aEs,
txNodeSet** aResult)
{
if (mNKeys == 0 || aNodes->isEmpty()) {
NS_ADDREF(*aResult = aNodes);
RefPtr<txNodeSet> ref(aNodes);
ref.forget(aResult);
return NS_OK;
}
@ -194,7 +195,7 @@ txNodeSorter::sortNodeSet(txNodeSet* aNodes, txExecutionState* aEs,
delete aEs->popEvalContext();
NS_ADDREF(*aResult = sortedNodes);
sortedNodes.forget(aResult);
return NS_OK;
}