Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 23:02:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1857866 - Enable ESLint rule mozilla/reject-importGlobalProperties on all of dom/. r=dom-storage-reviewers,janv

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D190434
This commit is contained in:
Mark Banner 2023-10-12 16:49:47 +00:00
parent 9fe5c005d6
commit 3ad8e86d7c
18 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.js
View File

@ -434,7 +434,6 @@ module.exports = {
"mozilla/avoid-removeChild": "off",
"mozilla/consistent-if-bracing": "off",
"mozilla/no-compare-against-boolean-literals": "off",
"mozilla/reject-importGlobalProperties": "off",
"mozilla/use-includes-instead-of-indexOf": "off",
"mozilla/use-ownerGlobal": "off",
"mozilla/use-services": "off",

2
dom/base/test/bug403852_fileOpener.js
View File

@ -1,7 +1,5 @@
/* eslint-env mozilla/chrome-script */
Cu.importGlobalProperties(["File"]);
var testFile = Cc["@mozilla.org/file/directory_service;1"]
.getService(Ci.nsIDirectoryService)
.QueryInterface(Ci.nsIProperties)

1
dom/base/test/bug578096LoadChromeScript.js
View File

@ -1,6 +1,7 @@
/* eslint-env mozilla/chrome-script */
var file;
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
addMessageListener("file.create", function (message) {

1
dom/base/test/file_bug1198095.js
View File

@ -1,5 +1,6 @@
/* eslint-env mozilla/chrome-script */
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
function createFileWithData(message) {

1
dom/base/test/script_bug1238440.js
View File

@ -1,5 +1,6 @@
/* eslint-env mozilla/chrome-script */
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
var tmpFile;

1
dom/base/test/script_postmessages_fileList.js
View File

@ -1,5 +1,6 @@
/* eslint-env mozilla/chrome-script */
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
addMessageListener("file.open", function () {

9
dom/file/ipc/tests/browser_ipcBlob.js
View File

@ -10,7 +10,6 @@ add_task(async function test_CtoPtoC_big() {
let browser1 = gBrowser.getBrowserForTab(tab1);
let blob = await SpecialPowers.spawn(browser1, [], function () {
Cu.importGlobalProperties(["Blob"]);
let blob = new Blob([new Array(1024 * 1024).join("123456789ABCDEF")]);
return blob;
});
@ -47,7 +46,6 @@ add_task(async function test_CtoPtoC_small() {
let browser1 = gBrowser.getBrowserForTab(tab1);
let blob = await SpecialPowers.spawn(browser1, [], function () {
Cu.importGlobalProperties(["Blob"]);
let blob = new Blob(["hello world!"]);
return blob;
});
@ -80,7 +78,6 @@ add_task(async function test_CtoPtoC_bc_big() {
let browser1 = gBrowser.getBrowserForTab(tab1);
await SpecialPowers.spawn(browser1, [], function () {
Cu.importGlobalProperties(["Blob"]);
var bc = new content.BroadcastChannel("test");
bc.onmessage = function () {
bc.postMessage(
@ -119,7 +116,6 @@ add_task(async function test_CtoPtoC_bc_small() {
let browser1 = gBrowser.getBrowserForTab(tab1);
await SpecialPowers.spawn(browser1, [], function () {
Cu.importGlobalProperties(["Blob"]);
var bc = new content.BroadcastChannel("test");
bc.onmessage = function () {
bc.postMessage(new Blob(["hello world!"]));
@ -156,7 +152,6 @@ add_task(async function test_CtoPtoC_bc_small() {
let browser1 = gBrowser.getBrowserForTab(tab1);
let blobURL = await SpecialPowers.spawn(browser1, [], function () {
Cu.importGlobalProperties(["Blob"]);
return content.URL.createObjectURL(new content.Blob(["hello world!"]));
});
@ -191,7 +186,6 @@ add_task(async function test_CtoPtoC_multipart() {
let browser1 = gBrowser.getBrowserForTab(tab1);
let blob = await SpecialPowers.spawn(browser1, [], function () {
Cu.importGlobalProperties(["Blob"]);
return new Blob(["!"]);
});
@ -204,7 +198,6 @@ add_task(async function test_CtoPtoC_multipart() {
let browser2 = gBrowser.getBrowserForTab(tab2);
let status = await SpecialPowers.spawn(browser2, [newBlob], function (blob) {
Cu.importGlobalProperties(["Blob"]);
return new Promise(resolve => {
let fr = new content.FileReader();
fr.readAsText(new Blob(["hello ", blob]));
@ -226,8 +219,6 @@ add_task(async function test_CtoPsize_multipart() {
let browser = gBrowser.getBrowserForTab(tab);
let blob = await SpecialPowers.spawn(browser, [], function () {
Cu.importGlobalProperties(["Blob"]);
let data = new Array(1024 * 512).join("A");
let blob1 = new Blob([data]);
let blob2 = new Blob([data]);

1
dom/file/ipc/tests/script_file.js
View File

@ -1,5 +1,6 @@
/* eslint-env mozilla/chrome-script */
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
addMessageListener("file.open", function (e) {

1
dom/file/tests/create_file_objects.js
View File

@ -1,5 +1,6 @@
/* eslint-env mozilla/chrome-script */
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
addMessageListener("create-file-objects", function (message) {

1
dom/file/tests/fileapi_chromeScript.js
View File

@ -1,5 +1,6 @@
/* eslint-env mozilla/chrome-script */
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
function createFileWithData(fileData) {

1
dom/html/test/browser_form_post_from_file_to_http.js
View File

@ -43,6 +43,7 @@ async function runTest(doNewTab) {
fileBrowser,
[TEST_HTTP_POST, filePaths, doNewTab],
(actionUri, filePaths, doNewTab) => {
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
let doc = content.document;

1
dom/html/test/formSubmission_chrome.js
View File

@ -1,5 +1,6 @@
/* eslint-env mozilla/chrome-script */
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
addMessageListener("files.open", function (message) {

1
dom/html/test/script_fakepath.js
View File

@ -1,5 +1,6 @@
/* eslint-env mozilla/chrome-script */
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
addMessageListener("file.open", function (e) {

1
dom/html/test/simpleFileOpener.js
View File

@ -1,5 +1,6 @@
/* eslint-env mozilla/chrome-script */
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
var file;

2
dom/quota/test/xpcshell/common/head.js
View File

@ -43,8 +43,6 @@ if (!this.runTest) {
enableStorageTesting();
enableTesting();
Cu.importGlobalProperties(["indexedDB", "File", "Blob", "FileReader"]);
// In order to support converting tests to using async functions from using
// generator functions, we detect async functions by checking the name of
// function's constructor.

1
dom/security/test/csp/file_report_chromescript.js
View File

@ -4,6 +4,7 @@ const { NetUtil } = ChromeUtils.importESModule(
"resource://gre/modules/NetUtil.sys.mjs"
);
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["TextDecoder"]);
const reportURI = "http://mochi.test:8888/foo.sjs";

1
dom/serviceworkers/test/script_file_upload.js
View File

@ -1,5 +1,6 @@
/* eslint-env mozilla/chrome-script */
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
addMessageListener("file.open", function (e) {

1
dom/workers/test/script_createFile.js
View File

@ -1,5 +1,6 @@
/* eslint-env mozilla/chrome-script */
// eslint-disable-next-line mozilla/reject-importGlobalProperties
Cu.importGlobalProperties(["File"]);
addMessageListener("file.open", function (e) {