Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 02:14:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1440677 - accept spaces and tabs in Content-Disposition header filename parameters because all the other browsers do, r=annevk,valentin,necko-reviewers

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D87130
This commit is contained in:
Gijs Kruitbosch 2020-08-19 16:10:20 +00:00
parent f3e1fbf443
commit 3bf91e4532
2 changed files with 31 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
netwerk/mime/nsMIMEHeaderParamImpl.cpp
View File

@ -497,10 +497,13 @@ nsresult nsMIMEHeaderParamImpl::DoParameterInternal(
if (*str != '"') {
// The value is a token, not a quoted string.
valueStart = str;
for (valueEnd = str;
*valueEnd && !nsCRT::IsAsciiSpace(*valueEnd) && *valueEnd != ';';
valueEnd++)
for (valueEnd = str; *valueEnd && *valueEnd != ';'; valueEnd++) {
;
}
// ignore trailing whitespace:
while (valueEnd > valueStart && nsCRT::IsAsciiSpace(*(valueEnd - 1))) {
valueEnd--;
}
str = valueEnd;
} else {
isQuotedString = true;

26
netwerk/test/unit/test_MIME_params.js
View File

@ -537,7 +537,10 @@ var tests = [
Cr.NS_ERROR_INVALID_ARG,
],
["attachment; filename=foo extension=bla", "attachment", "foo"],
// Bug 1440677 - spaces inside filenames ought to be quoted, but too many
// servers do the wrong thing and most browsers accept this, so we were
// forced to do the same for compat.
["attachment; filename=foo extension=bla", "attachment", "foo extension=bla"],
["attachment filename=foo", "attachment", Cr.NS_ERROR_INVALID_ARG],
@ -555,6 +558,27 @@ var tests = [
// Bug 1412213 - do continue to parse, behind a parameter w/o =
["attachment; badparameter; filename=foo", "attachment", "foo"],
// Bug 1440677 - spaces inside filenames ought to be quoted, but too many
// servers do the wrong thing and most browsers accept this, so we were
// forced to do the same for compat.
["attachment; filename=foo bar.html", "attachment", "foo bar.html"],
// Note: we keep the tab character, but later validation will replace with a space,
// as file systems do not like tab characters.
["attachment; filename=foo\tbar.html", "attachment", "foo\tbar.html"],
// Newlines get stripped completely (in practice, http header parsing may
// munge these into spaces before they get to us, but we should check we deal
// with them either way):
["attachment; filename=foo\nbar.html", "attachment", "foobar.html"],
["attachment; filename=foo\r\nbar.html", "attachment", "foobar.html"],
["attachment; filename=foo\rbar.html", "attachment", "foobar.html"],
// Trailing rubbish shouldn't matter:
["attachment; filename=foo bar; garbage", "attachment", "foo bar"],
["attachment; filename=foo bar; extension=blah", "attachment", "foo bar"],
// Check that whitespace processing can't crash.
["attachment; filename = ", "attachment", ""],
];
var rfc5987paramtests = [