Bug 582216 - Make sure that we set _scrollTarget in every case in order to address intermittent failures in tabbrowser overflow handling; r=dao

This commit is contained in:
Hiroyuki Ikezoe 2011-03-16 18:01:34 -04:00
parent 28a4c2e085
commit 3d28e162ef

View File

@ -247,8 +247,7 @@
this._stopSmoothScroll();
if (aSmoothScroll != false && this.smoothScroll) {
this._scrollTarget = element;
this._smoothScrollByPixels(amountToScroll);
this._smoothScrollByPixels(amountToScroll, element);
} else {
this.scrollByPixels(amountToScroll);
}
@ -257,12 +256,13 @@
<method name="_smoothScrollByPixels">
<parameter name="amountToScroll"/>
<parameter name="element"/><!-- optional -->
<body><![CDATA[
this._stopSmoothScroll();
if (amountToScroll == 0)
return;
this._stopSmoothScroll();
this._scrollTarget = element;
// Positive amountToScroll makes us scroll right (elements fly left), negative scrolls left.
this._isScrolling = amountToScroll < 0 ? -1 : 1;