Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-07 03:45:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix up ordering issues in radiogroups. Bug 226549, r=neil, sr=alecf

Browse Source
This commit is contained in:
bzbarsky%mit.edu 2003-12-03 04:40:03 +00:00
parent e4d53231f8
commit 3d66acfc68
1 changed files with 24 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
xpfe/global/resources/content/bindings/radio.xml
View File

@ -185,23 +185,27 @@
]]>
</body>
</method>
<field name="mRadioChildren">[]</field>
<field name="mRadioChildren">null</field>
<method name="_getRadioChildren">
<parameter name="aNode">this</parameter>
<parameter name="aNode" />
<body>
<![CDATA[
if (aNode) {
if (aNode == this && this.mRadioChildren)
if (!aNode)
aNode = this;
if (aNode == this) {
if (this.mRadioChildren)
return this.mRadioChildren;
else if (aNode.localName == "radio") {
this.mRadioChildren[this.mRadioChildren.length++] = aNode;
return this.mRadioChildren;
}
else if (aNode.localName == "radiogroup" && aNode != this)
return this.mRadioChildren;
for (var i = 0; i < aNode.childNodes.length; ++i)
this._getRadioChildren(aNode.childNodes[i]);
else
this.mRadioChildren = new Array();
}
else if (aNode.localName == "radio") {
this.mRadioChildren[this.mRadioChildren.length++] = aNode;
return this.mRadioChildren;
}
else if (aNode.localName == "radiogroup" && aNode != this)
return this.mRadioChildren;
for (var i = 0; i < aNode.childNodes.length; ++i)
this._getRadioChildren(aNode.childNodes[i]);
return this.mRadioChildren;
]]>
</body>
@ -343,16 +347,18 @@
<implementation implements="nsIDOMXULSelectControlItemElement, nsIAccessibleProvider">
<constructor>
<![CDATA[
var parent = this.radioGroup;
parent.mRadioChildren[parent.mRadioChildren.length++] = this;
// Just clear out the parent's cached list of radio children
this.radioGroup.mRadioChildren = null;
]]>
</constructor>
<destructor>
<![CDATA[
var parent = this.radioGroup;
for (var i = 0; i < parent.mRadioChildren.length; ++i) {
if (parent.mRadioChildren[i] == this) {
parent.mRadioChildren.slice(i, i);
var radioList = this.radioGroup.mRadioChildren;
if (!radioList)
return;
for (var i = 0; i < radioList.length; ++i) {
if (radioList[i] == this) {
radioList.splice(i, 1);
return;
}
}