Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-30 00:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1017896 - Ensure there is a template contents owner when creating template elements. r=bz

Browse Source
This commit is contained in:
William Chen 2014-06-03 16:09:41 -07:00
parent 7ffb8ff042
commit 3d94034ff8
5 changed files with 49 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
content/base/src/nsDocument.cpp
View File

@ -4513,6 +4513,11 @@ nsDocument::SetScriptGlobalObject(nsIScriptGlobalObject *aScriptGlobalObject)
// doing the initial document load and don't want to fire the event for this
// change.
mVisibilityState = GetVisibilityState();
// The global in the template contents owner document should be the same.
if (mTemplateContentsOwner && mTemplateContentsOwner != this) {
mTemplateContentsOwner->SetScriptGlobalObject(aScriptGlobalObject);
}
}
nsIScriptGlobalObject*
@ -9443,7 +9448,6 @@ nsDocument::GetTemplateContentsOwner()
bool hasHadScriptObject = true;
nsIScriptGlobalObject* scriptObject =
GetScriptHandlingObject(hasHadScriptObject);
NS_ENSURE_TRUE(scriptObject || !hasHadScriptObject, nullptr);
nsCOMPtr<nsIDOMDocument> domDocument;
nsresult rv = NS_NewDOMDocument(getter_AddRefs(domDocument),
@ -9461,12 +9465,16 @@ nsDocument::GetTemplateContentsOwner()
mTemplateContentsOwner = do_QueryInterface(domDocument);
NS_ENSURE_TRUE(mTemplateContentsOwner, nullptr);
mTemplateContentsOwner->SetScriptHandlingObject(scriptObject);
nsDocument* doc = static_cast<nsDocument*>(mTemplateContentsOwner.get());
doc->mHasHadScriptHandlingObject = hasHadScriptObject;
if (!scriptObject) {
mTemplateContentsOwner->SetScopeObject(GetScopeObject());
}
// Set |doc| as the template contents owner of itself so that
// |doc| is the template contents owner of template elements created
// by |doc|.
nsDocument* doc = static_cast<nsDocument*>(mTemplateContentsOwner.get());
doc->mTemplateContentsOwner = doc;
}

28
content/html/content/src/HTMLTemplateElement.cpp
View File

@ -11,21 +11,7 @@
#include "nsIAtom.h"
#include "nsRuleData.h"
using namespace mozilla::dom;
nsGenericHTMLElement*
NS_NewHTMLTemplateElement(already_AddRefed<nsINodeInfo>&& aNodeInfo,
FromParser aFromParser)
{
HTMLTemplateElement* it = new HTMLTemplateElement(aNodeInfo);
nsresult rv = it->Init();
if (NS_FAILED(rv)) {
delete it;
return nullptr;
}
return it;
}
NS_IMPL_NS_NEW_HTML_ELEMENT(Template)
namespace mozilla {
namespace dom {
@ -34,18 +20,14 @@ HTMLTemplateElement::HTMLTemplateElement(already_AddRefed<nsINodeInfo>& aNodeInf
: nsGenericHTMLElement(aNodeInfo)
{
SetHasWeirdParserInsertionMode();
}
nsresult
HTMLTemplateElement::Init()
{
nsIDocument* contentsOwner = OwnerDoc()->GetTemplateContentsOwner();
NS_ENSURE_TRUE(contentsOwner, NS_ERROR_UNEXPECTED);
if (!contentsOwner) {
MOZ_CRASH("There should always be a template contents owner.");
}
mContent = contentsOwner->CreateDocumentFragment();
mContent->SetHost(this);
return NS_OK;
}
HTMLTemplateElement::~HTMLTemplateElement()
@ -77,7 +59,7 @@ NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED(HTMLTemplateElement)
NS_INTERFACE_MAP_END_INHERITING(nsGenericHTMLElement)
NS_IMPL_ELEMENT_CLONE_WITH_INIT(HTMLTemplateElement)
NS_IMPL_ELEMENT_CLONE(HTMLTemplateElement)
JSObject*
HTMLTemplateElement::WrapNode(JSContext *aCx)

2
content/html/content/src/HTMLTemplateElement.h
View File

@ -28,8 +28,6 @@ public:
virtual nsresult Clone(nsINodeInfo *aNodeInfo, nsINode **aResult) const MOZ_OVERRIDE;
nsresult Init();
DocumentFragment* Content()
{
return mContent;

1
dom/tests/mochitest/webcomponents/mochitest.ini
View File

@ -3,6 +3,7 @@ support-files =
inert_style.css
[test_bug900724.html]
[test_bug1017896.html]
[test_content_element.html]
[test_nested_content_element.html]
[test_dest_insertion_points.html]

32
dom/tests/mochitest/webcomponents/test_bug1017896.html Normal file
View File

@ -0,0 +1,32 @@
<!DOCTYPE HTML>
<html>
<!--
https://bugzilla.mozilla.org/show_bug.cgi?id=1017896
-->
<head>
<title>Test template element in stale document.</title>
<script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
</head>
<body>
<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1017896">Bug 1017896</a>
<div id="container"></div>
<script>
SimpleTest.waitForExplicitFinish();
var frame = document.createElement("iframe");
document.getElementById("container").appendChild(frame);
var staleFrameDoc = frame.contentDocument;
setTimeout(function() {
var v = staleFrameDoc.createElement("div");
v.innerHTML = "<template>Content</template>";
is(v.firstChild.content.childNodes.length, 1, "Template should have one child in template content.");
SimpleTest.finish();
}, 0);
</script>
</body>
</html>