Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 21:01:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1825061 - Fix Hulu caption observer. r=pip-reviewers,mhowell

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D174003
This commit is contained in:
Niklas Baumgardner 2023-03-30 00:31:58 +00:00
parent 8779346ead
commit 3db97ae681
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
browser/extensions/pictureinpicture/video-wrappers/hulu.js
View File

@ -33,8 +33,22 @@ class PictureInPictureVideoWrapper {
if (container) {
updateCaptionsFunction("");
const callback = function(mutationsList, observer) {
let text = container.innerText;
updateCaptionsFunction(text);
// This will get the subtitles for both live and regular playback videos
// and combine them to display. liveVideoText should be an empty string
// when the video is regular playback and vice versa. If both
// liveVideoText and regularVideoText are non empty strings, which
// doesn't seem to be the case, they will both show.
let liveVideoText = Array.from(
container.querySelectorAll(
"#inband-closed-caption > div > div > div"
),
x => x.textContent.trim()
)
.filter(String)
.join("\n");
let regularVideoText = container.querySelector(".CaptionBox").innerText;
updateCaptionsFunction(liveVideoText + regularVideoText);
};
// immediately invoke the callback function to add subtitles to the PiP window