Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-18 15:55:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1679044: Remove unused safepoints. r=iain

Browse Source 
LValueToInt32:
- Safepoints are only needed for LValueToInt32::TRUNCATE and LValueToInt32::TRUNCATE_NOWRAP

LIteratorMore and LIteratorEnd:
- Safepoints are no longer needed.
- Bug 1525674 removed the OOL VM calls.

LGetNextEntryForIterator:
- Safepoint was never needed to begin with.
- A previous iteration used an OOL VM call, but that iteration didn't never land, cf. bug 1248289.

LGuardHasGetterSetter:
- Safepoint was never needed to begin with, because it only calls an ABI function.

Differential Revision: https://phabricator.services.mozilla.com/D97888
This commit is contained in:
André Bargull 2020-11-30 14:16:53 +00:00
parent de2f970c09
commit 3e277bfd64
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
js/src/jit/Lowering.cpp
View File

@ -2121,7 +2121,10 @@ void LIRGenerator::visitToNumberInt32(MToNumberInt32* convert) {
LValueToInt32::NORMAL);
assignSnapshot(lir, convert->bailoutKind());
define(lir, convert);
assignSafepoint(lir, convert);
if (lir->mode() == LValueToInt32::TRUNCATE ||
lir->mode() == LValueToInt32::TRUNCATE_NOWRAP) {
assignSafepoint(lir, convert);
}
break;
}
@ -2997,7 +3000,6 @@ void LIRGenerator::visitGetNextEntryForIterator(MGetNextEntryForIterator* ins) {
useRegister(ins->result()),
temp(), temp(), temp());
define(lir, ins);
assignSafepoint(lir, ins);
}
void LIRGenerator::visitArrayBufferByteLengthInt32(
@ -4532,7 +4534,6 @@ void LIRGenerator::visitIteratorMore(MIteratorMore* ins) {
LIteratorMore* lir =
new (alloc()) LIteratorMore(useRegister(ins->iterator()), temp());
defineBox(lir, ins);
assignSafepoint(lir, ins);
}
void LIRGenerator::visitIsNoIter(MIsNoIter* ins) {
@ -4544,7 +4545,6 @@ void LIRGenerator::visitIteratorEnd(MIteratorEnd* ins) {
LIteratorEnd* lir = new (alloc())
LIteratorEnd(useRegister(ins->iterator()), temp(), temp(), temp());
add(lir, ins);
assignSafepoint(lir, ins);
}
void LIRGenerator::visitStringLength(MStringLength* ins) {
@ -5487,7 +5487,6 @@ void LIRGenerator::visitGuardHasGetterSetter(MGuardHasGetterSetter* ins) {
assignSnapshot(guard, ins->bailoutKind());
add(guard, ins);
redefine(ins, object);
assignSafepoint(guard, ins);
}
void LIRGenerator::visitConstant(MConstant* ins) {