Bug 1583886: Fix yet more untested content windows which open chrome windows. r=nika

Differential Revision: https://phabricator.services.mozilla.com/D47135

--HG--
extra : moz-landing-system : lando

security/manager/pki/resources/content/certManager.js

@@ -332,7 +332,7 @@ function editCerts() {
   getSelectedCerts();
 
   for (let cert of selected_certs) {
-    window.openDialog(
+    window.docShell.rootTreeItem.domWindow.openDialog(
       "chrome://pippki/content/editcacert.xul",
       "",
       "chrome,centerscreen,modal",
@@ -460,7 +460,7 @@ function deleteCerts() {
   let retVals = {
     deleteConfirmed: false,
   };
-  window.openDialog(
+  window.docShell.rootTreeItem.domWindow.openDialog(
     "chrome://pippki/content/deletecert.xul",
     "",
     "chrome,centerscreen,modal",

security/manager/pki/resources/content/device_manager.js

@@ -326,7 +326,11 @@ function doLogout() {
 
 // load a new device
 function doLoad() {
-  window.open("load_device.xul", "loaddevice", "chrome,centerscreen,modal");
+  window.docShell.rootTreeItem.domWindow.open(
+    "load_device.xul",
+    "loaddevice",
+    "chrome,centerscreen,modal"
+  );
   ClearDeviceList();
   RefreshDeviceList();
 }
@@ -361,7 +365,7 @@ function changePassword() {
   let objects = Cc["@mozilla.org/array;1"].createInstance(Ci.nsIMutableArray);
   objects.appendElement(selected_slot.getToken());
   params.objects = objects;
-  window.openDialog(
+  window.docShell.rootTreeItem.domWindow.openDialog(
     "changepassword.xul",
     "",
     "chrome,centerscreen,modal",

toolkit/content/aboutSupport.js

@@ -1489,11 +1489,11 @@ function setupEventListeners() {
     button = $("show-update-history-button");
     if (button) {
       button.addEventListener("click", function(event) {
-        let uri = "chrome://mozapps/content/update/history.xul";
-        let features =
-          "chrome,centerscreen,resizable=no,titlebar,toolbar=no," +
-          "dialog=yes,modal";
-        Services.ww.openWindow(window, uri, "Update:History", features, null);
+        window.docShell.rootTreeItem.domWindow.openDialog(
+          "chrome://mozapps/content/update/history.xul",
+          "Update:History",
+          "centerscreen,resizable=no,titlebar,modal"
+        );
       });
     }
   }

toolkit/modules/ResetProfile.jsm

@@ -54,10 +54,10 @@ var ResetProfile = {
     let params = {
       reset: false,
     };
-    window.openDialog(
+    window.docShell.rootTreeItem.domWindow.openDialog(
       "chrome://global/content/resetProfile.xul",
       null,
-      "chrome,modal,centerscreen,titlebar,dialog=yes",
+      "modal,centerscreen,titlebar",
       params
     );
     if (!params.reset) {