Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 14:22:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Split multiple id deletes into 100-id chunks instead of hitting max apache URI length.

Browse Source
This commit is contained in:
Edward Lee 2009-10-12 18:11:31 -07:00
parent f56a03aa93
commit 3f44aa854b
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
services/sync/modules/engines.js
View File

@ -637,14 +637,26 @@ SyncEngine.prototype = {
this._log.trace("Finishing up sync");
this._tracker.resetScore();
let doDelete = Utils.bind2(this, function(key, val) {
let coll = new Collection(this.engineURL, this._recordObj);
coll[key] = val;
coll.delete();
});
for (let [key, val] in Iterator(this._delete)) {
// Remove the key for future uses
delete this._delete[key];
// Send a delete for the property
let coll = new Collection(this.engineURL, this._recordObj);
coll[key] = val;
coll.delete();
// Send a simple delete for the property
if (key != "ids" || val.length <= 100)
doDelete(key, val);
else {
// For many ids, split into chunks of at most 100
while (val.length > 0) {
doDelete(key, val.slice(0, 100));
val = val.slice(100);
}
}
}
},