Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 05:41:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1598559 - Do not forget runnable within loop. r=dom-workers-and-storage-reviewers,janv

Browse Source 
Reverts regression introduced by 449a5f02a960116e0f901ae3570170ab642ecea0.

Differential Revision: https://phabricator.services.mozilla.com/D54497

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Simon Giesecke 2019-11-25 14:30:54 +00:00
parent 1ac11b47bd
commit 4006617c93
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dom/indexedDB/ActorsParent.cpp
View File

@ -11422,7 +11422,13 @@ bool ConnectionPool::ScheduleTransaction(TransactionInfo* aTransactionInfo,
// We need a thread right now so force all idle processing to stop by
// posting a dummy runnable to each thread that might be doing idle
// maintenance.
nsCOMPtr<nsIRunnable> runnable = new Runnable("IndexedDBDummyRunnable");
//
// This is copied for each database inside the loop below, it is
// deliberately const to prevent the attempt to wrongly optimize the
// refcounting by passing runnable.forget() to the Dispatch method, see
// bug 1598559.
const nsCOMPtr<nsIRunnable> runnable =
new Runnable("IndexedDBDummyRunnable");
for (uint32_t index = mDatabasesPerformingIdleMaintenance.Length();
index > 0; index--) {
@ -11431,7 +11437,7 @@ bool ConnectionPool::ScheduleTransaction(TransactionInfo* aTransactionInfo,
MOZ_ASSERT(dbInfo->mThreadInfo.mThread);
MOZ_ALWAYS_SUCCEEDS(dbInfo->mThreadInfo.mThread->Dispatch(
runnable.forget(), NS_DISPATCH_NORMAL));
runnable, NS_DISPATCH_NORMAL));
}
}