Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-03 10:33:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1480852 Crash in android.os.TransactionTooLargeException: data parcel size 1053364 bytes at android.os.BinderProxy.transactNative(Native Method) r=jchen

Browse Source 
Added an extra check of bundle size due to some unexpected transactions sizes that exceed the limit.
The bundle gets lighter if the size exceeds the limit by removing the views' state as a last resort.

Differential Revision: https://phabricator.services.mozilla.com/D5682

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Andrei Lazar 2018-09-14 11:24:33 +00:00
parent e557551409
commit 403853306a
2 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
View File

@ -183,6 +183,7 @@ import java.util.Locale;
import java.util.regex.Pattern;
import static org.mozilla.gecko.mma.MmaDelegate.NEW_TAB;
import static org.mozilla.gecko.util.JavaUtil.getBundleSizeInBytes;
public class BrowserApp extends GeckoApp
implements ActionModePresenter,
@ -213,6 +214,8 @@ public class BrowserApp extends GeckoApp
private static final String BROWSER_SEARCH_TAG = "browser_search";
private static final int MAX_BUNDLE_SIZE = 300000; // 300 kilobytes
// Request ID for startActivityForResult.
public static final int ACTIVITY_REQUEST_PREFERENCES = 1001;
private static final int ACTIVITY_REQUEST_TAB_QUEUE = 2001;
@ -2267,6 +2270,15 @@ public class BrowserApp extends GeckoApp
super.onSaveInstanceState(outState);
mDynamicToolbar.onSaveInstanceState(outState);
outState.putInt(STATE_ABOUT_HOME_TOP_PADDING, mHomeScreenContainer.getPaddingTop());
// Under key “android:viewHierarchyState” the OS stores another object of type Bundle.
// This bundle stores the state of the view which is in a SparseArray that can grow pretty big.
// This in some cases can lead to TransactionTooLargeException as per
// [https://developer.android.com/reference/android/os/TransactionTooLargeException] it's
// specified that the limit is fixed to 1MB per process.
if (getBundleSizeInBytes(outState) > MAX_BUNDLE_SIZE) {
outState.remove("android:viewHierarchyState");
}
}
/**

14
mobile/android/base/java/org/mozilla/gecko/util/JavaUtil.java
View File

@ -5,6 +5,9 @@
package org.mozilla.gecko.util;
import android.os.Bundle;
import android.os.Parcel;
import java.util.List;
public class JavaUtil {
@ -21,4 +24,15 @@ public class JavaUtil {
}
list.set(to, movedTab);
}
public static int getBundleSizeInBytes(Bundle bundle) {
Parcel parcel = Parcel.obtain();
int size;
parcel.writeBundle(bundle);
size = parcel.dataSize();
parcel.recycle();
return size;
}
}