Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-11 04:15:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1365309 - Part 3: Disable ThreadStackHelper on x86 linux due to a LUL crash, r=froydnj

Browse Source 
MozReview-Commit-ID: 2kBBFftnJEd
This commit is contained in:
Michael Layzell 2017-06-12 12:46:23 -04:00
parent 806614c9f6
commit 403cfbc0a1
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
toolkit/components/telemetry/tests/unit/xpcshell.ini
View File

@ -52,7 +52,7 @@ tags = addons
tags = addons
[test_TelemetrySession_activeTicks.js]
[test_ThreadHangStats.js]
skip-if = os == "android" || os == "linux" # BHR is disabled on linux (bug 1365309)
skip-if = os == "android" || (os == "linux" && bits == 32) # BHR is disabled on 32-bit linux
run-sequentially = Bug 1046307, test can fail intermittently when CPU load is high
[test_TelemetrySend.js]
[test_ChildHistograms.js]

6
xpcom/threads/ThreadStackHelper.h
View File

@ -22,8 +22,10 @@
#include <mach/mach.h>
#endif
// Support pseudostack and native stack on these platforms.
#if defined(XP_LINUX) || defined(XP_WIN) || defined(XP_MACOSX)
// Support pseudostack and native stack on these platforms. We don't support
// collecting this information on x86 linux builds, as our LUL stackwalking
// initialization code can occasionally crash. (see bug 1365309 comment 8).
#if (defined(XP_LINUX) && defined(HAVE_64BIT_BUILD)) || defined(XP_WIN) || defined(XP_MACOSX)
# ifdef MOZ_GECKO_PROFILER
# define MOZ_THREADSTACKHELPER_PSEUDO
# define MOZ_THREADSTACKHELPER_NATIVE