Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 17:55:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1631501 [wpt PR 23119] - Fix inline box positions when RTL and has trailing spaces, a=testonly

Browse Source 
Automatic update from web-platform-tests
Fix inline box positions when RTL and has trailing spaces

This patch fixes inline box positions when the line is in RTL
and has preserved trailing spaces.

Two issues were found for this case:
a. Computes incorrect value for how much the line hangs.
b. When hang is not zero, inline box positions are incorrect.

This patch fixes the issue b.

The issue a is related but does not contribute to the
reported symptom. It should be worked with better trailing
space support and UAX#9 L1 support (crbug.com/316409). TODO
comment added for this issue.

Bug: 1062716
Change-Id: Ie33db517ebc886a724116b594699f8d59751c808
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156235
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760793}

--

wpt-commits: 44215ed1f182054fdd55a43035b70041b50d61b0
wpt-pr: 23119
This commit is contained in:
Koji Ishii 2020-04-28 11:33:55 +00:00 committed by moz-wptsync-bot
parent dc1589a012
commit 408e92d24a
2 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
testing/web-platform/tests/css/css-text/white-space/reference/trailing-space-rtl-001-ref.html Normal file
View File

@ -0,0 +1,19 @@
<!DOCTYPE html>
<style>
body {
direction: rtl;
white-space: pre-wrap;
}
.bg {
background: orange;
}
.override {
unicode-bidi: bidi-override;
}
</style>
<body>
<div>אבג <span class="bg">אבגד</span> אבגדה</div>
<div>אבג <span class="bg">אבגד</span> אבגדה</div>
<div class="override">123 <span class="bg override">12345</span> 1234567</div>
<div class="override">123 <span class="bg override">12345</span> 1234567</div>
</body>

23
testing/web-platform/tests/css/css-text/white-space/trailing-space-rtl-001.html Normal file
View File

@ -0,0 +1,23 @@
<!DOCTYPE html>
<title>CSS Test: Preserved trailing spaces in RTL</title>
<link rel="match" href="reference/trailing-space-rtl-001-ref.html">
<link rel="help" href="https://drafts.csswg.org/css-text-3/#white-space-phase-2">
<link rel="author" title="Koji Ishii" href="mailto:kojii@chromium.org">
<style>
body {
direction: rtl;
white-space: pre-wrap;
}
.bg {
background: orange;
}
.override {
unicode-bidi: bidi-override;
}
</style>
<body>
<div>אבג <span class="bg">אבגד</span> אבגדה</div>
<div>אבג <span class="bg">אבגד</span> אבגדה </div>
<div class="override">123 <span class="bg override">12345</span> 1234567</div>
<div class="override">123 <span class="bg override">12345</span> 1234567 </div>
</body>