Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-14 20:22:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 806822: avoid race condition in gathering stats r=ehugg

Browse Source
This commit is contained in:
Randell Jesup 2012-12-11 07:58:53 -05:00
parent 38c1bec0e2
commit 412ada1719
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_ipc.c
View File

@ -597,17 +597,20 @@ cprSendMessage (cprMsgQueue_t msgQueue, void *msg, void **ppUserData)
*/
if (msgq->extendedQDepth < msgq->maxExtendedQDepth) {
rc = cprPostExtendedQMsg(msgq, msg, ppUserData);
// do under lock to avoid races
if (rc == CPR_MSGQ_POST_SUCCESS) {
cprPegSendMessageStats(msgq, numAttempts);
} else {
msgq->sendErrors++;
}
(void) pthread_mutex_unlock(&msgq->mutex);
if (rc == CPR_MSGQ_POST_SUCCESS) {
cprPegSendMessageStats(msgq, numAttempts);
return CPR_SUCCESS;
}
else
{
CPR_ERROR(error_str, fname, msgq->name, "no memory");
msgq->sendErrors++;
return CPR_FAILURE;
}
}